fix(react): don't re-anchor historical turns on same-count content changes#11182
Open
devnomic wants to merge 1 commit into
Open
fix(react): don't re-anchor historical turns on same-count content changes#11182devnomic wants to merge 1 commit into
devnomic wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11181
The bug
MessageScrollerscrolls a historical anchor to the reading line (usually the very top of the thread) whenever a content mutation replaces one child with another at the same item count. The canonical trigger is the standard chat pattern: send appends the user turn + a pending loader, then the first streamed chunk swaps the loader for the assistant item in one commit. Every turn, the viewport jumps to the oldest unhandled user message.Cause: the first-content branch of
handleContentChangenever adds initially mounted anchors tohandledScrollAnchorsRef, and the same-count branch scans the whole list for any never-handled anchor — so it matches anchors that mounted with the initial content instead of only just-swapped-in ones.The fix
Mark every current anchor as handled at the end of each
handleContentChangepass (newmarkScrollAnchorsHandledhelper ingeometry.ts). An anchor still gets exactly the reconcile pass that introduced it:still anchors a new turn swapped in at the same counttest,does not re-anchor a historical turn when an item is swapped at the same counttest, which fails onmainand passes with this change.The two inline
handledScrollAnchorsRef.current.add(anchor)calls became redundant and were removed.Tests
pnpm --filter @shadcn/react test— 60 passedpnpm --filter @shadcn/react test:browser— 25 passed (both new regression tests fail without the source change)pnpm --filter @shadcn/react typecheck— clean