fix(v4): size chevron icon in base breadcrumb dropdown example#11204
Merged
Conversation
The dropdown trigger renders a plain button, so the ChevronDownIcon had no size constraint and rendered at lucide's 24px default. Add size-3.5 to match the breadcrumb-rtl example.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added
className="size-3.5"to theChevronDownIconinside the dropdown trigger inapps/v4/examples/base/breadcrumb-dropdown.tsx.Why
The trigger renders a plain
<button>via Base UI'srenderprop (not theButtoncomponent), so nothing constrained the svg size — the chevron rendered at lucide's 24×24px default, oversized next to the breadcrumb text.Notes for reviewers
size-3.5matches the identical trigger pattern in thebreadcrumb-rtl.tsxexample. Verified in the browser at/examples/base/breadcrumb-dropdown— the chevron now computes to 14×14px.