Skip to content

fix: guard empty MsgSend amounts - #1283

Merged
kaladinlight merged 3 commits into
developfrom
fix/fox-295-empty-msgsend-panic
Aug 18, 2026
Merged

fix: guard empty MsgSend amounts#1283
kaladinlight merged 3 commits into
developfrom
fix/fox-295-empty-msgsend-panic

Conversation

@0xApotheosis

Copy link
Copy Markdown
Member

Description

Guards MsgSend parsing so empty amount collections are skipped before Amount[0].

  • Covers custom and bank sends across THORChain, MayaChain, and Cosmos.
  • Adds regression coverage for empty amounts.
  • Fixes the thorchain-v1 Railway watch path so shared THORChain changes trigger a rebuild.

Addresses FOX-295.

Verification

  • GOTOOLCHAIN=go1.25.4 go test ./... in go/pkg/thorchain
  • GOTOOLCHAIN=go1.25.4 go test ./... in go/pkg/cosmos
  • MayaChain test compilation reached the link step locally; the macOS host cannot link the repository Linux-only libzec.so.

@0xApotheosis
0xApotheosis requested a review from a team as a code owner July 22, 2026 09:36
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a2c13802-cee8-4aa2-84cb-a2273d2c3cf4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fox-295-empty-msgsend-panic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kaladinlight
kaladinlight changed the base branch from main to develop August 18, 2026 17:26
@kaladinlight
kaladinlight merged commit 7b0c7a7 into develop Aug 18, 2026
3 checks passed
@kaladinlight
kaladinlight deleted the fix/fox-295-empty-msgsend-panic branch August 18, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants