Add Shavit_StopReplay & Shavit_GetClientReplayBot natives - #1292
Merged
Conversation
Collaborator
|
Looks rightish but I didn't test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was previously no clean way to stop a replay bot:
Replay_Centralbots, there was no way to stop one at all. Forcibly kicking it would leave it missing for up to several seconds until the cron timer respawns it.Replay_Dynamicbots, the only option wasKickClientExto kick the bot in the same frame.Replay_Propbots, the only option was RemoveEdict, which destroys the prop and bypassesShavit_OnReplayEnd.OnEntityDestroyed, which handlesReplay_Props that mysteriously die, only kicks them (KickReplay) rather than finishing them (FinishReplay)