V2: nag only when no license key is saved (2.1.0)

[shazzad]

Summary

The V2 admin notice now shows only when no license key is saved. An expired license no longer gets a sitewide notice.

Decided 2026-09-15 while testing pimipay-wc-paddle PR #67. The expired notice appeared on every admin screen (including WooCommerce → Payments) and came back weekly after dismissal. An expired plugin keeps working; only updates stop. So the notice was more nag than help.

What changes

• src/V2/Admin/Notices.php: removes the expired notice type, its renew message, and its snooze type. TYPES is now [ 'unlicensed' ].
• Unchanged: the unlicensed notice, its one-week snooze, the snooze option key, and the plugins-screen deferral (is_covered_by_update_row).
• Expiry information stays where the product lives:
  • the license page (status and renewal_url link)
  • the plugins-list update row (V2\Admin\UpdateMessage)
  • get_license_status() and get_license_renewal_url()
• V1 (frozen) is untouched. It never had notices.
• CHANGELOG (2.1.0), README, and CLAUDE.md updated.

Notes

• Leftover option: sites that snoozed the old expired notice keep a {storage}_notice_snooze_expired option. Nothing reads it now; it's harmless, so there's no migration.
• Consumers:
  • pimipay-wc-paddle PR #67 will bump to ^2.1 once this is tagged.
  • LoxoWP gets the change on its next updater bump.
• Release: tag 2.1.0, no v prefix. Not tagged; this PR is not merged.

Test plan

• New: an expired license with a key renders no notice, and get_notice_type() returns ''.
• New: a snooze request for the removed expired type is ignored.
• Existing unlicensed, active, capability, license-page, plugins-screen and snooze tests still pass.
• composer test: 213 tests, 389 assertions, OK (the same 6 risky no-assertion tests as on main).
• PHP 7.4 compatibility check (phpcs-check) is clean.
• composer phpcs (WordPress standard) exits non-zero, but that's pre-existing: 180 errors and 48 warnings in 13 files, identical counts on main and this branch (Notices.php 11 errors on both).

🤖 Generated with Claude Code

https://claude.ai/code/session_013VELFUvbdtn26TuL14hpJz

[shazzad]

Reverted on main (ce7de82) and released as 2.1.1, which restores the expired-license notice exactly as in 2.0.1. The updater is shared by many products, so it doesn't change for one product. 2.1.0 was withdrawn (tag and release deleted) before any consumer picked it up.