Skip to content

refactor: sweep leaky naming suffixes#41

Merged
kostyafarber merged 3 commits intomainfrom
firmclaw/naming-sweep-payload-state-data
Apr 26, 2026
Merged

refactor: sweep leaky naming suffixes#41
kostyafarber merged 3 commits intomainfrom
firmclaw/naming-sweep-payload-state-data

Conversation

@kostyafarber
Copy link
Copy Markdown
Collaborator

@kostyafarber kostyafarber commented Apr 20, 2026

Summary

  • remove a first batch of leaky suffix names across bridge, persistence, editor, and glyph-info code
  • rename transient select and pen helper types to more intentional names
  • tighten docs and exported aliases to match the naming direction

Included in this PR

  • payload/data/state/descriptor/result renames in the touched TS and Rust bridge surfaces
  • -> , ->
  • select drag-state helper renames (, , etc.)
  • pen helper renames (, )
  • alias removal in favor of

Validation

@shift/desktop@0.0.1 typecheck /home/firmclaw/repos/shift/apps/desktop
tsc --noEmit -p tsconfig.build.json

@shift/validation@0.0.1 test /home/firmclaw/repos/shift/packages/validation
vitest run

Notes

  • this is intentionally a first sweep from the naming ticket, not the entire naming program
  • manager renames and the domain refactor should stay separate

@kostyafarber kostyafarber force-pushed the firmclaw/naming-sweep-payload-state-data branch from cbe56cb to 5e71f46 Compare April 26, 2026 19:42
Follow-up to the first naming sweep:

- PointStepResult/RotateStepResult -> PointStep/RotateStep
- PointSnapResult/RotateSnapResult -> PointSnap/RotateSnap
- ClosestPointResult -> ClosestPoint
- GlyphCategoryCatalogData -> GlyphCategoryCatalogIndex

Restore GlyphData.xml as the vendor file path. The first commit renamed it to Glyph.xml, but GlyphData.xml is the upstream schriftgestalt/GlyphsInfo file name and not under our control — this was the cause of CI failure on this PR.

Also extend the no-console-log hook glob from scripts/* to also match */scripts/* so nested package script files (which legitimately use console.log) are not flagged.
@kostyafarber kostyafarber merged commit 61d1e7b into main Apr 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant