use HMAC-SHA256 for the cookie string - #450
Merged
Merged
Conversation
briskt
requested review from
ethancanne,
forevermatt,
jason-jackson and
mtompset
and removed request for
a team
July 29, 2026 05:49
hobbitronics
approved these changes
Jul 29, 2026
Contributor
Author
|
@devon-sil do you think this will be a change that requires an email blast? It will cause everyone to be prompted for MFA on their next login. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MFA “remember me” cookie hashing/verification logic to avoid bcrypt’s 72-character input limit by switching to an HMAC-based approach for cookie integrity checking.
Changes:
- Replace
password_hash/password_verifywithhash_hmac('sha256', ...)+hash_equals()for remember-me cookie validation. - Update
generateRememberMeCookieString()to no longer embed the secret in the string being hashed. - Adjust the MFA unit test to generate the cookie hash using HMAC-SHA256.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/mfa/src/Auth/Process/Mfa.php | Switch remember-me cookie hashing/verification to HMAC-SHA256 and update cookie string generation accordingly. |
| modules/mfa/tests/MfaTest.php | Update test to reflect the new remember-me cookie hashing method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDP-2186 Verify and fix bcrypt in sspbase
Fixed