Skip to content

Fix dropped session on Assertion Response - #451

Merged
briskt merged 5 commits into
mainfrom
samesite
Aug 4, 2026
Merged

Fix dropped session on Assertion Response#451
briskt merged 5 commits into
mainfrom
samesite

Conversation

@briskt

@briskt briskt commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

IDP-2273 ssp-base 12.2.5 regression in hub mode


Changed (non-breaking)

  • Run the test hub from behind Caddy so secure cookies can be used during test.

Fixed

  • Fixed a longstanding issue that caused the hub session cookie to not be read on the assertion response path (redirect back from the IdP). The latest update to simplesamlphp (2.5.2) makes this a failure point for some SPs. The solution is to set the SameSite attribute in the Set-Cookie header to "none".

@briskt
briskt requested a review from a team as a code owner July 31, 2026 14:11
@briskt
briskt requested review from ethancanne, forevermatt, jason-jackson and mtompset and removed request for a team July 31, 2026 14:11

@hobbitronics hobbitronics left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Easier to to follow with the separate commit.

Comment thread .github/workflows/test-and-publish.yml
@briskt
briskt merged commit 227d9c1 into main Aug 4, 2026
2 checks passed
@briskt
briskt deleted the samesite branch August 4, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants