Skip to content

Address spacing and indentation feedback from DLS - #1105

Merged
FyreByrd merged 6 commits into
mainfrom
fix/dls-feedback
Aug 7, 2026
Merged

Address spacing and indentation feedback from DLS#1105
FyreByrd merged 6 commits into
mainfrom
fix/dls-feedback

Conversation

@FyreByrd

@FyreByrd FyreByrd commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes

    • Improved search input handling when the field is unavailable, preventing errors while inserting special characters.
    • Prevented missing theme settings from causing styling issues.
    • Refined dictionary entry rendering and style application for more consistent formatting.
  • Improvements

    • Search now defaults to whole-word matching.
    • Search page and results titles are localized.
    • Enhanced support for configured single-entry styles, including inline block display options.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e2bfea3-688d-4eea-87ea-c4fbbbfd7ee2

📥 Commits

Reviewing files that changed from the base of the PR and between 2156026 and 86c3d34.

📒 Files selected for processing (1)
  • src/lib/lexicon/components/EntryView.svelte
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/lib/lexicon/components/EntryView.svelte

📝 Walkthrough

Walkthrough

The changes guard optional search elements and theme values, apply configured entry styles conditionally, move raw HTML styling to the <pre> element, enable whole-word search by default, and localize search titles.

Changes

Lexicon updates

Layer / File(s) Summary
Search form safety and theme lookups
src/lib/components/SearchForm.svelte
Special-character insertion and style lookups now tolerate unavailable input or theme values.
Conditional entry styling and raw HTML rendering
src/lib/lexicon/components/EntryView.svelte
Entry identifiers are used consistently. Single-entry styles apply only when enabled and configured. Block displays can become inline, and inline styles apply directly to <pre>.
Lexicon route wiring and search presentation
src/routes/lexicon/+page.svelte, src/routes/lexicon/search/+page.svelte
The lexicon page imports bodyLineHeight. Search defaults to whole-word matching and uses localized titles.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the DLS feedback addressed by the changes, including spacing, indentation, styling, and related cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dls-feedback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FyreByrd
FyreByrd marked this pull request as ready for review August 7, 2026 14:22

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/lib/lexicon/components/EntryView.svelte`:
- Around line 231-234: Update the single-entry condition in EntryView’s
modify-single-entry-styles block to check _wordIDs.length instead of
wordIDs.value.length, so prop-provided searchIDs determine whether styles apply.
Preserve the existing feature-flag check and styling behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ec170d57-a33b-4ce0-aeeb-0345887f4af4

📥 Commits

Reviewing files that changed from the base of the PR and between 25ad042 and 2156026.

📒 Files selected for processing (4)
  • src/lib/components/SearchForm.svelte
  • src/lib/lexicon/components/EntryView.svelte
  • src/routes/lexicon/+page.svelte
  • src/routes/lexicon/search/+page.svelte

Comment thread src/lib/lexicon/components/EntryView.svelte
@FyreByrd
FyreByrd merged commit 5573e14 into main Aug 7, 2026
3 of 4 checks passed
@FyreByrd
FyreByrd deleted the fix/dls-feedback branch August 7, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant