Skip to content

Grant contents:write to fw-lite create-release job - #2526

Merged
hahn-kev merged 1 commit into
developfrom
fix/fw-lite-create-release-permissions
Aug 5, 2026
Merged

Grant contents:write to fw-lite create-release job#2526
hahn-kev merged 1 commit into
developfrom
fix/fw-lite-create-release-permissions

Conversation

@hahn-kev

@hahn-kev hahn-kev commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

the last release was blocked due to permissions


AI summary

fw-lite.yaml sets a workflow-level permissions: contents: read, which caps every job that doesn't declare its own block. The create-release job (which only runs on main) publishes a GitHub release via softprops/action-gh-release, and creating a release + tag requires contents: write. With only read, the token is rejected.

This job was never exercised on develop/PRs, so the shortfall stayed hidden until the release path fired on main. This adds a job-level permissions: contents: write to create-release, restoring the scope it needs without widening any other job.

Part of the same batch of permission fixes as the release-pipeline.yaml changes (top-level packages: write + checks: write, and contents: read on the integration-tests job), which are already on develop.

Test plan

  • Merge to develop, then confirm on the next main release that the Create Release job in fw-lite.yaml completes and publishes the release.

The workflow-level permissions block restricts all jobs to
contents:read, but create-release uses softprops/action-gh-release
to publish a GitHub release, which needs contents:write. This only
runs on main, so it wasn't exercised until the release path fired.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The release workflow now grants the create-release job contents: write permission so it can create GitHub releases.

Changes

Release workflow permissions

Layer / File(s) Summary
Create-release permission
.github/workflows/fw-lite.yaml
The create-release job declares contents: write permission.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: myieye

Poem

I’m a rabbit with a release to make,
With write permission in my wake.
The workflow hops, the tags align,
A GitHub release appears on time.
Squeak—deploy complete!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the permission change for the fw-lite release job.
Description check ✅ Passed The description explains the permission failure, the targeted fix, and the planned validation.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fw-lite-create-release-permissions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hahn-kev hahn-kev added the self-reviewed 👁️ I reviewed this myself and with AI and decided it was safe to merge without a second set of eyes label Aug 5, 2026
@argos-ci

argos-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Aug 5, 2026, 4:03 AM
e2e (Inspect) ✅ No changes detected - Aug 5, 2026, 4:12 AM

@hahn-kev
hahn-kev merged commit f40775d into develop Aug 5, 2026
17 checks passed
@hahn-kev
hahn-kev deleted the fix/fw-lite-create-release-permissions branch August 5, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

self-reviewed 👁️ I reviewed this myself and with AI and decided it was safe to merge without a second set of eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant