Grant contents:write to fw-lite create-release job - #2526
Merged
Conversation
The workflow-level permissions block restricts all jobs to contents:read, but create-release uses softprops/action-gh-release to publish a GitHub release, which needs contents:write. This only runs on main, so it wasn't exercised until the release path fired. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThe release workflow now grants the ChangesRelease workflow permissions
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the last release was blocked due to permissions
AI summary
fw-lite.yamlsets a workflow-levelpermissions: contents: read, which caps every job that doesn't declare its own block. Thecreate-releasejob (which only runs onmain) publishes a GitHub release viasoftprops/action-gh-release, and creating a release + tag requirescontents: write. With onlyread, the token is rejected.This job was never exercised on
develop/PRs, so the shortfall stayed hidden until the release path fired onmain. This adds a job-levelpermissions: contents: writetocreate-release, restoring the scope it needs without widening any other job.Part of the same batch of permission fixes as the
release-pipeline.yamlchanges (top-levelpackages: write+checks: write, andcontents: readon theintegration-testsjob), which are already ondevelop.Test plan
develop, then confirm on the nextmainrelease that theCreate Releasejob infw-lite.yamlcompletes and publishes the release.