Skip to content

[PT ext] Sync template and update package-lock - #2527

Merged
imnasnainaec merged 2 commits into
developfrom
pt-ext/sync-from-template
Aug 5, 2026
Merged

[PT ext] Sync template and update package-lock#2527
imnasnainaec merged 2 commits into
developfrom
pt-ext/sync-from-template

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

The updates in the template fix 2 things:

A transitive dependency that we need (but the extension template doesn't) was lost when updating package-lock.json, so this pr also adds it explicitly in devDependencies.


Devin: https://app.devin.ai/review/sillsdev/languageforge-lexbox/pull/2527

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Webpack now compiles TypeScript for ES2022 and configures Sass to emit expanded output before PostCSS processing.

Changes

Webpack Build Configuration

Layer / File(s) Summary
SWC ES2022 compilation target
platform.bible-extension/webpack/webpack.config.base.ts
SWC now targets ES2022 for TypeScript compilation.
Expanded Sass output
platform.bible-extension/webpack/webpack.config.base.ts
The Sass loader now sets sassOptions.style to expanded.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit with a build to run,
ES2022 makes subclassing fun.
Sass spreads wide in a tidy display,
PostCSS can parse it on its way.
Hop, hop—clean bundles today!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the template synchronization and package-lock update described in the pull request.
Description check ✅ Passed The description directly explains the template fixes and the explicit devDependency added after the package-lock update.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pt-ext/sync-from-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@imnasnainaec
imnasnainaec merged commit b8ce422 into develop Aug 5, 2026
7 checks passed
@imnasnainaec
imnasnainaec deleted the pt-ext/sync-from-template branch August 5, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants