Skip to content

Allow passing a null pointer to swAlignModel_getTrainingAlignment #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmachapman merged 2 commits into from
Aug 10, 2026
Merged

Allow passing a null pointer to swAlignModel_getTrainingAlignment #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb88e51
Allow passing a null pointer to swAlignModel_getTrainingAlignment
pmachapman Aug 5, 2026
8cc1cdf
Use getSentencePair to calculate getTrainingAlignment dimensions
pmachapman Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Release/
*.nupkg
.vs/
.vscode/
.idea/

build*/
artifacts/
Expand Down
11 changes: 11 additions & 0 deletions src/shared_library/thot.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,6 +1092,17 @@ extern "C"
{
auto alignmentModel = static_cast<AlignmentModel*>(swAlignModelHandle);

if (matrix == nullptr)
{
// Retrieve the dimensions of the training alignment matrix for sentence pair n
Count c;
std::vector<std::string> srcSentence, trgSentence;
alignmentModel->getSentencePair(n, srcSentence, trgSentence, c);
*iLen = (unsigned int)srcSentence.size();
*jLen = (unsigned int)trgSentence.size();
return SMALL_LG_NUM;
}

WordAlignmentMatrix waMatrix;
LgProb prob = alignmentModel->getTrainingAlignment(n, waMatrix);
// A filtered/out-of-range pair yields an empty matrix, so clamp to its actual
Expand Down
Loading