SF-3869 Add configuration for single pane view - #4008
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4008 +/- ##
==========================================
+ Coverage 81.04% 81.05% +0.01%
==========================================
Files 659 659
Lines 42761 42779 +18
Branches 6994 7026 +32
==========================================
+ Hits 34657 34676 +19
+ Misses 6960 6945 -15
- Partials 1144 1158 +14 ☔ View full report in Codecov by Harness. |
RaymondLuong3
left a comment
There was a problem hiding this comment.
This is neat. Thanks for these changes. The editor updates in real-time and that is nice. The only thing I noticed is the the disabled form of the toggle is highlighted purple, the activated form is green. But since that was the existing colours for the lynx toggle, that is not a big issue.
@RaymondLuong3 reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts line 4176 at r2 (raw file):
const spyCreateTab = spyOn(env.tabFactory, 'createTab').and.callThrough(); env.wait(); expect(spyCreateTab).not.toHaveBeenCalledWith('project-resource', jasmine.any(Object));
This doesn't look right. I would have expected this line to expect that spyCreateTab is called with this resource.
Code quote:
expect(spyCreateTab).not.toHaveBeenCalledWith('project-resource', jasmine.any(Object));
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts line 4176 at r2 (raw file):
Previously, RaymondLuong3 (Raymond Luong) wrote…
This doesn't look right. I would have expected this line to expect that
spyCreateTabis called with this resource.
Done. Thank you for spotting this - I have corrected the test.
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
This PR adds a setting to the Translator Settings dialog that allows showing all editor tabs in one pane.
This change is