Skip to content

SF-3869 Add configuration for single pane view - #4008

Open
pmachapman wants to merge 1 commit into
masterfrom
fix/SF-3869
Open

SF-3869 Add configuration for single pane view#4008
pmachapman wants to merge 1 commit into
masterfrom
fix/SF-3869

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a setting to the Translator Settings dialog that allows showing all editor tabs in one pane.


This change is Reviewable

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.05%. Comparing base (637ea89) to head (8624e34).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4008      +/-   ##
==========================================
+ Coverage   81.04%   81.05%   +0.01%     
==========================================
  Files         659      659              
  Lines       42761    42779      +18     
  Branches     6994     7026      +32     
==========================================
+ Hits        34657    34676      +19     
+ Misses       6960     6945      -15     
- Partials     1144     1158      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@pmachapman
pmachapman temporarily deployed to screenshot_diff July 28, 2026 22:54 — with GitHub Actions Inactive
@pmachapman pmachapman changed the title WIP: SF-3869 Add configuration for single pane view SF-3869 Add configuration for single pane view Jul 29, 2026
@pmachapman
pmachapman marked this pull request as ready for review July 29, 2026 00:02
@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jul 29, 2026
@pmachapman
pmachapman temporarily deployed to screenshot_diff July 29, 2026 00:09 — with GitHub Actions Inactive
@RaymondLuong3 RaymondLuong3 self-assigned this Jul 30, 2026

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat. Thanks for these changes. The editor updates in real-time and that is nice. The only thing I noticed is the the disabled form of the toggle is highlighted purple, the activated form is green. But since that was the existing colours for the lynx toggle, that is not a big issue.

@RaymondLuong3 reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jul 30, 2026

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts line 4176 at r2 (raw file):

        const spyCreateTab = spyOn(env.tabFactory, 'createTab').and.callThrough();
        env.wait();
        expect(spyCreateTab).not.toHaveBeenCalledWith('project-resource', jasmine.any(Object));

This doesn't look right. I would have expected this line to expect that spyCreateTab is called with this resource.

Code quote:

        expect(spyCreateTab).not.toHaveBeenCalledWith('project-resource', jasmine.any(Object));

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).


src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts line 4176 at r2 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

This doesn't look right. I would have expected this line to expect that spyCreateTab is called with this resource.

Done. Thank you for spotting this - I have corrected the test.

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants