Skip to content

Use an exclusive component name label #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fgiorgetti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use an exclusive component name label #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions components/management-controller/src/resource-templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const APPLICATION = "vms";
const ROUTER_LABEL = "vms-router";
const CM_NAME = "skupper-internal";
const DEPLOYMENT_NAME = "vms-site";
const COMPONENT_NAME = "site-controller";

export function HashOfData(data) {
let text = "";
Expand Down Expand Up @@ -397,7 +398,7 @@ export function Deployment(bsid, backboneMode, target, imageOverride) {
labels: {
"app.kubernetes.io/name": DEPLOYMENT_NAME,
"app.kubernetes.io/part-of": "vms",
"skupper.io/component": "router",
"skupper.io/component": COMPONENT_NAME,
application: APPLICATION,
},
name: DEPLOYMENT_NAME,
Expand All @@ -408,7 +409,7 @@ export function Deployment(bsid, backboneMode, target, imageOverride) {
revisionHistoryLimit: 10,
selector: {
matchLabels: {
"skupper.io/component": "router",
"skupper.io/component": COMPONENT_NAME,
},
},
strategy: {
Expand All @@ -424,7 +425,7 @@ export function Deployment(bsid, backboneMode, target, imageOverride) {
"app.kubernetes.io/name": DEPLOYMENT_NAME,
"app.kubernetes.io/part-of": "vms",
application: ROUTER_LABEL,
"skupper.io/component": "router",
"skupper.io/component": COMPONENT_NAME,
},
},
spec: {
Expand Down