Skip to content

Stop getSemanticHTML from turning every space into   #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afonsojanu wants to merge 1 commit into from
Closed

Stop getSemanticHTML from turning every space into   #4827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/quill/src/core/editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,13 @@ function convertHTML(
}
if (blot instanceof TextBlot) {
const escapedText = escapeText(blot.value().slice(index, index + length));
return escapedText.replaceAll(' ', ' ');
// A single space between words renders fine as-is; only a run of two or
// more needs non-breaking spaces, since HTML would otherwise collapse
// the run down to one space and change the text's meaning.
return escapedText.replace(
/ {2,}/g,
(spaces) => ' '.repeat(spaces.length - 1) + ' ',
);
}
if (blot instanceof ParentBlot) {
// TODO fix API
Expand Down
16 changes: 16 additions & 0 deletions packages/quill/test/unit/core/quill.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,22 @@ describe('Quill', () => {
'"el"',
);
});

test('keeps a single space between words as a plain space', () => {
const quill = new Quill(
createContainer('<p>a text with multiple spaces</p>'),
);
expect(quill.getSemanticHTML()).toMatchInlineSnapshot(
`"<p>a text with multiple spaces</p>"`,
);
});

test('preserves a run of consecutive spaces with non-breaking spaces', () => {
const quill = new Quill(createContainer('<p>a&nbsp;&nbsp; b</p>'));
expect(quill.getSemanticHTML()).toMatchInlineSnapshot(
`"<p>a&nbsp;&nbsp; b</p>"`,
);
});
});

describe('setText()', () => {
Expand Down