Repository navigation
fix(toolbar): preserve selection inside modal dialogs - #4835
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4796.
Prevent primary-button mousedown on an attached toolbar button from moving focus away from the editor. This preserves the selected range inside a native modal dialog, so a slow click can apply formatting and the next click can remove it. Keyboard activation and select controls retain their existing behavior.
Added browser regressions for modal and non-modal dialogs, slow pointer clicks, repeated formatting, and keyboard activation. The Chromium modal regression fails on the original code; all six new cases pass in Chromium, Firefox, and WebKit after the fix.
Validation: 93 E2E tests, 521 unit tests, package lint/type checks, and the production webpack bundle passed. The full package build is blocked by an existing
WebpackError.prepareStackTracedeclaration incompatibility (TS2417), reproduced on the unchanged base as well; no dependency or build configuration changes are included.Assisted-by: Codex