fix: autofetch via LrcLib + state-aware "no lyrics" message - #7
Merged
Merged
Conversation
The interactive `f` picker added in #6 queries LrcLib directly (the most reliable synced-lyrics source), but the silent autofetch still only used `syncedlyrics.search(synced_only=True)`, which frequently returns nothing. So the picker found lyrics while the autofetch reported "not found" — it looked like autofetch had stopped working. - simple_search() now tries LrcLib first (same source as the `f` panel), then falls back to the syncedlyrics providers. - _start_autofetch() no longer bails with "no_module" when syncedlyrics is absent: LrcLib (requests) alone is enough. - The empty-lyrics message now reflects the autofetch state: searching…, autofetch found nothing / failed → press f, and the plain hint when autofetch is disabled/unavailable. Bump version to 0.5.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the interactive
fpicker landed in #6, the automatic (silent) autofetch appeared to stop working: opening thefpanel found lyrics, but the autofetch reported "not found" for the same track.Root cause: the
fpanel queries LrcLib directly (the most reliable synced-lyrics source), while the autofetch still relied solely onsyncedlyrics.search(synced_only=True), which frequently returns nothing.Changes
simple_search()(used by the autofetch) now tries LrcLib first — the same source as thefpanel — returning the first synced LRC it finds, then falls back to the syncedlyrics providers._start_autofetch()no longer bails withno_modulewhensyncedlyricsis absent: LrcLib (viarequests) alone is enough.Searching lyrics online…press fpress f to fetch…hint (unchanged)Test
Live check against LrcLib confirmed
_lrclib_first_synced("Bohemian Rhapsody Queen")returns a 2502-char synced LRC.🤖 Generated with Claude Code