PanoramaView is showing one/same action menu for all hosts

[kafos]

Describe the bug
Different hosts with different action_menu are using all the same action menu. No matter what kind of icons or widgets.

Version**
Thruk 3.23.20250802
OMD 5.61~2025-08-02-labs-edition

To Reproduce
Steps to reproduce the behavior:

1. In Panarama View create new Hosts table (and filter for hosts with action menus)
2. all hosts menus have the same action menu but should be different

Same:
create a host Icon and add the correct action menu with "Link" -> Predefined Links
--> still opens a false action menu

It seems that Panorama view is using the last alphabetical *.js menu from thruk/action_menus/

In THRUK is everything ok!

Screenshots

Want to open correct action menu.

Opens another action_menu --> in our case "shelly_menu.js":

[kafos]

it that issue reproducible?

[kafos]

Tried with newest version and issue still present. Every host has the same action menu in panorama view. In thruk everythink is ok.

[kafos]

I finally found what causes this, so here's the explanation in case it helps.

All of our action menus are .js files and every one of them defined its entry function with the same name (function menu(cfg)). That's what breaks it.

Panorama collects all js action menus and concatenates them into a single global blob, sorted by name:

plugins/panorama/lib/Thruk/Controller/panorama.pm

for my $name (sort keys %{$c->config->{'action_menu_items'}}) {
my $menu = Thruk::Utils::Filter::get_action_menu($c, $name);
$action_menu_items_js .= delete $menu->{'data'} if $menu->{'type'} eq 'js';
At click time the menu is looked up through the global namespace:

// panorama_js_panlet_icon_widget_functions.js:501
else if(menu.type == "js" && menu["function"] && window[menu["function"]]) {
menuData = windowmenu["function"];
So if two files declare a function with the same name, the one that comes last alphabetically overwrites all the others, and every menu pointing at that name renders the same thing. In our case zsalzburg.js was last, which is why every host showed its menu.

Regular Thruk isn't affected because _blocks.tt inserts the file and calls print_action_menu() right after it, while the correct definition is still the active one.

To reproduce: two .js action menus, both with function menu(...) as the first function, assigned to different hosts. In Thruk both work, in Panorama both show whatever the alphabetically last file returns.

Note that files get registered twice (as name and name.js), so each one also ends up in the blob twice.

Workaround for anyone hitting this: give every action menu file a unique function name. We renamed ours to __ and it's been fine since.

A real fix would be to keep the functions out of window — wrap each file in its own scope and store the result under the menu name.

Versions: OMD 5.71.20260808-labs-edition, Thruk 3.29.20260808.

[sni]

Thanks for the detailed analysis. Right, having the same function defined multiple times is not supported. It will probably break outside Panorama View as well if there are multiple hosts with different menus.