Skip to content

TreeDB collections: reuse semantic document IDs in direct buffered updates #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snissn wants to merge 1 commit into
base: codex/1242-pr3b-semantic-value-diff-fastpath
Choose a base branch
from
+13 −5
Open

TreeDB collections: reuse semantic document IDs in direct buffered updates #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions TreeDB/collections/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9223,15 +9223,23 @@ func applyDirectBufferedRootEntries(table memtable.Table, entries []directBuffer
})
}

func buildIndexedSemanticUpdateRecords(collectionName string, runtimes []indexRuntime, updates []preparedBatchUpdate) []indexedSemanticRecord {
func buildIndexedSemanticUpdateRecords(collectionName string, runtimes []indexRuntime, updates []preparedBatchUpdate, primaryEntries []directBufferedRootEntry) []indexedSemanticRecord {
if len(updates) == 0 {
return nil
}
records := make([]indexedSemanticRecord, 0, len(updates))
for _, update := range updates {
for i, update := range updates {
var documentID []byte
if i < len(primaryEntries) && len(primaryEntries[i].key) > 0 {
// Direct primary entries are built from the same changed slice and carry
// an owned, staged document ID clone, so the semantic sidecar can share it.
documentID = primaryEntries[i].key
} else {
documentID = bytes.Clone(update.documentID)
}
record := indexedSemanticRecord{
kind: indexedSemanticRecordUpdate,
documentID: bytes.Clone(update.documentID),
documentID: documentID,
}
if update.indexStateChanged && len(runtimes) > 0 {
for runtimeIdx, runtime := range runtimes {
Expand Down Expand Up @@ -10425,7 +10433,7 @@ func (c *Collection) buildUpdateBatchPlan(items []UpdateBatchItem, mode updateBa
stats = updateCollectionUpdateStatsCounts(stats, results, len(rootNames))
var semanticRecords []indexedSemanticRecord
if c.writeDomain != nil && canBufferIndexedUpdateBatch && meta.Options.BufferedIndexedWrites {
semanticRecords = buildIndexedSemanticUpdateRecords(meta.Name, runtimes, changed)
semanticRecords = buildIndexedSemanticUpdateRecords(meta.Name, runtimes, changed, primaryEntries)
}
*plan = updateBatchPlan{
results: results,
Expand Down Expand Up @@ -10629,7 +10637,7 @@ func (c *Collection) buildUpdateBatchPlan(items []UpdateBatchItem, mode updateBa
stats = updateCollectionUpdateStatsCounts(stats, results, len(deltaTables))
var semanticRecords []indexedSemanticRecord
if c.writeDomain != nil && canBufferIndexedUpdateBatch && meta.Options.BufferedIndexedWrites {
semanticRecords = buildIndexedSemanticUpdateRecords(meta.Name, runtimes, changed)
semanticRecords = buildIndexedSemanticUpdateRecords(meta.Name, runtimes, changed, nil)
}
*plan = updateBatchPlan{
results: results,
Expand Down
Loading