[codex] batch leaf log split appends - #1496
Draft
snissn wants to merge 1 commit into
Draft
Conversation
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shortens the leaf-log append critical path for split sibling leaves without changing leaf-generation liveness semantics.
Changes:
LeafPageBatchLogpath in the zipperAppendLeafPagesfor the caching leaf-page log so sibling leaf pages can be compacted before entering the value-log append path and persisted through one append callCorrectness note
I intentionally did not batch bulk-build leaf generation in this PR. A broader batching attempt caused
TestLeafGenerationPack_RewritesCollectionInternalRootsBeforeGCto fail because dead-byte accounting no longer saw the expected dead leaf records. This PR keeps the safe split-sibling batching only and keeps outer-leaf frames at one leaf record per frame.Performance evidence
Correctness guard that specifically protects leaf-generation accounting:
Result:
Focused package tests:
Result:
Example update benchmark run on this branch:
Selected result line:
Leaf-log/root-apply metrics from the same run:
Full local benchmark output was saved under
/tmp/gomap_leaflog_pr_validation_*on the development host.