[codex] docs: align Raft R3a with command WAL - #1656
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree specification documents are updated to establish the Raft R3a deterministic apply harness design: architectural roadmap positioning, normative contract for command eligibility and apply boundaries, and command-WAL alignment categorization mapping each command to its harness status. ChangesRaft R3a Deterministic Apply Harness Specification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR aligns the documentation roadmap/specs for TreeDB’s Raft direction with the newer “user-command WAL” approach by explicitly introducing an R3a milestone for a deterministic apply harness and annotating the existing native-wire ↔ command-WAL alignment manifest with R3a eligibility metadata.
Changes:
- Add explicit “R3a. Deterministic Apply Harness” milestone and acceptance criteria to the native query/Raft roadmap.
- Link the new Raft R3a tracker (#1654) from the user-command WAL spec and add R3a-oriented narrative clarifying the apply-harness scope.
- Extend the native-wire/command-WAL alignment manifest with R3a harness eligibility values and per-command eligibility annotations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TreeDB/docs/spec/user-command-wal.md | Adds Raft R3a tracker link and describes how the alignment manifest constrains the R3a apply-harness allowlist/rejections. |
| TreeDB/docs/spec/native-query-raft-roadmap.md | Introduces the R3a deterministic apply-harness milestone and adjusts R3 replication scope language to match WAL-supported commands. |
| TreeDB/docs/spec/command-wal-nativewire-alignment.json | Adds R3a tracker + harness eligibility taxonomy and annotates each native-wire mutation with an R3a harness eligibility value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "owner": "TreeDB/docs/spec/user-command-wal.md", | ||
| "tracker": "https://github.com/snissn/gomap/issues/1529", | ||
| "raft_r3a_tracker": "https://github.com/snissn/gomap/issues/1654", | ||
| "relationship_values": [ | ||
| "lowered_equivalent_v1", | ||
| "lowered_kind_only_v1", | ||
| "future_rejected_v1", | ||
| "local_only_rejected_v1", | ||
| "local_only_barrier_v1" | ||
| ], | ||
| "raft_r3a_harness_values": [ | ||
| "eligible_v1", | ||
| "rejected_until_wal_supported_v1", | ||
| "local_only_not_replicated_v1" | ||
| ], |
Summary
Scope
Docs/spec only. No code behavior, storage format, or public API changes.
Validation
jq empty TreeDB/docs/spec/command-wal-nativewire-alignment.jsonGOWORK=off go test ./TreeDB/docs -count=1GOWORK=off make docs-checkgit diff --checkRefs #1654.
Summary by CodeRabbit