Avoid q2 per-row global code remap - #3327
Closed
snissn wants to merge 3 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ost-prepare-lazy-3324
…ost-prepare-lazy-3324
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production-path caveat
A 1M JSONBench full-data q2
one_shot_end_to_end/no_aggregate_metadatarun against this branch showed the production q2 cell currently uses dense grouped-count-distinct (dense_group_count_distinct_used=true,sort_layout=time_us), not the sorted grouped-distinct path changed here.Latest artifact:
/tmp/jsonbench_q2_lazy_1m_pUFYuebb/report.json85.240ms, setup65.209ms, run19.986ms, post-prepare40.849ms0.061ms, distinct rank34.566ms, local rank6.221ms1,000,000 / 954,611 / 954,611b63b8e1013c918fcda7c299ef64beb20c4988854cf0671a83803b6951d795860So this PR is a valid sorted grouped-distinct algorithmic experiment, but it should not be presented as the production JSONBench full-data q2 improvement. The production q2 follow-up now targets dense grouped-count-distinct distinct-rank/local-rank setup; see #3324.
Claim boundary
This is no-aggregate one-shot typed-column q2 setup work only. It is not metadata acceleration evidence and is not a ClickHouse superiority claim. The PR stays draft until a production or harness q2 cell that actually exercises the sorted grouped-distinct path has current 1M evidence.
Validation
git diff --checkGOWORK=off go test ./TreeDB/collections -run 'TestColumnPhysicalTypedColumnOneShotCacheQ2NoMetadata3123|TestTypedColumnQ2.*1950|TestTypedColumnQ2DenseGroupCountDistinctRankMapCapacity3158' -count=1GOWORK=off go test ./TreeDB/collections -count=1Evidence still required
Refs #3324. Refs #3070.