Avoid q2 sorted per-row global-code remap - #3433
Draft
snissn wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 1, 2026
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope / claim boundary
This is no-aggregate one-shot typed-column query setup work for q2 sorted grouped-distinct execution only. It is not metadata acceleration, and it should not be presented as ClickHouse superiority until current side-by-side evidence is regenerated.
The standard JSONBench full-prepared q2 path currently reports
dense_group_count_distinct_used=true; that dense path remains separate and still uses its existing dense global-code/rank preparation. This PR is therefore still draft until we either attach a standard sorted-path acceptance artifact or explicitly decide to land it as a narrow sorted-path cleanup.Evidence so far
Focused tests:
All passed locally.
Exploratory 1M Bluesky sorted-path probe, using a temporary exported-API probe outside the repo:
Standard JSONBench q2 1M one-shot/no-metadata artifact against this branch:
/tmp/jsonbench_q2_lazy_rank_1m_20260701_065655/report.jsoncolumn-store-full-preparedone_shot_end_to_endno_aggregate_metadatadense_group_count_distinct_used=trueb63b8e1013c918fcda7c299ef64beb20c4988854cf0671a83803b6951d795860This standard artifact is useful q2 context/no-regression evidence, but it does not prove the sorted grouped-distinct change because the standard path is dense.
Acceptance evidence still required before merge
Refs #3324
Refs #3070