Skip to content

SNOW-2912540: use IS_V5_DRIVER for cursor request_id access - #4314

Open
sfc-gh-fpawlowski wants to merge 2 commits into
SNOW-2912540-secret-detector-importfrom
SNOW-2912540-request-id-compat
Open

SNOW-2912540: use IS_V5_DRIVER for cursor request_id access#4314
sfc-gh-fpawlowski wants to merge 2 commits into
SNOW-2912540-secret-detector-importfrom
SNOW-2912540-request-id-compat

Conversation

@sfc-gh-fpawlowski

@sfc-gh-fpawlowski sfc-gh-fpawlowski commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • The UD's SnowflakeCursor exposes the client-generated request UUID as a public request_id property; _request_id is only a backward-compat alias slated for removal.
  • The legacy v4 connector is the opposite: it only ever sets self._request_id as a plain instance attribute in cursor.py, with no public request_id property at all.
  • Branch on IS_V5_DRIVER at the one call site that reads this — execute_and_notify_query_listener in server_connection.py — and its unit test mock.
  • Investigated (but left untouched) the other _request_id-named attributes in the repo: AstBatch._request_id and AstBuilder's request-id generation are Snowpark's own self-generated UUIDs for the AST Bind/Eval batching protocol — unrelated to the connector cursor, same name by coincidence.

Test plan

  • grep -rn "\._request_id\b" src/ tests/ confirms only the AST-batch (unrelated) and the fixed call sites remain

Checklist

  • I acknowledge that I have ensured my changes to be thread-safe

Stack (via Graphite)

🤖 Generated with Claude Code

@codecov-commenter

codecov-commenter commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (SNOW-2912540-secret-detector-import@6568b8e). Learn more about missing BASE report.

Additional details and impacted files
@@                          Coverage Diff                           @@
##             SNOW-2912540-secret-detector-import    #4314   +/-   ##
======================================================================
  Coverage                                       ?   95.44%           
======================================================================
  Files                                          ?      172           
  Lines                                          ?    44771           
  Branches                                       ?     7682           
======================================================================
  Hits                                           ?    42730           
  Misses                                         ?     1264           
  Partials                                       ?      777           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from SNOW-2912540-secret-detector-import to graphite-base/4314 August 20, 2026 16:28
@sfc-gh-fpawlowski
sfc-gh-fpawlowski force-pushed the SNOW-2912540-request-id-compat branch from 9a8a97c to 3417aaf Compare August 20, 2026 16:29
@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from graphite-base/4314 to SNOW-2912540-secret-detector-import August 20, 2026 16:29
@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from SNOW-2912540-secret-detector-import to graphite-base/4314 August 20, 2026 17:13
@sfc-gh-fpawlowski
sfc-gh-fpawlowski force-pushed the SNOW-2912540-request-id-compat branch from 3417aaf to c8a6bc2 Compare August 20, 2026 17:14
@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from graphite-base/4314 to SNOW-2912540-secret-detector-import August 20, 2026 17:14
@sfc-gh-fpawlowski
sfc-gh-fpawlowski force-pushed the SNOW-2912540-request-id-compat branch from c8a6bc2 to 20dace5 Compare August 21, 2026 07:00
@sfc-gh-fpawlowski
sfc-gh-fpawlowski force-pushed the SNOW-2912540-request-id-compat branch from 20dace5 to 084818f Compare August 21, 2026 07:40
@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from SNOW-2912540-secret-detector-import to graphite-base/4314 August 21, 2026 08:31
@sfc-gh-fpawlowski
sfc-gh-fpawlowski force-pushed the SNOW-2912540-request-id-compat branch from bc81d4f to 8255b78 Compare August 21, 2026 08:32
@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from graphite-base/4314 to SNOW-2912540-secret-detector-import August 21, 2026 08:32
The UD's SnowflakeCursor exposes the client-generated request UUID as
a public `request_id` property; `_request_id` is only a backward-compat
alias slated for removal. The legacy v4 connector is the opposite: it
only ever sets `self._request_id` as a plain instance attribute and has
no public `request_id` property. Branch on IS_V5_DRIVER in the one call
site that reads this (execute_and_notify_query_listener) and its unit
test mock.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from SNOW-2912540-secret-detector-import to graphite-base/4314 August 21, 2026 09:36
@sfc-gh-fpawlowski
sfc-gh-fpawlowski force-pushed the SNOW-2912540-request-id-compat branch from 8255b78 to cec387a Compare August 21, 2026 09:36
@sfc-gh-fpawlowski
sfc-gh-fpawlowski changed the base branch from graphite-base/4314 to SNOW-2912540-secret-detector-import August 21, 2026 09:36
Blocks pre-commit's insert-py-license hook (and therefore "Check linting",
which gates the entire test matrix) for every branch stacked on top of
this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants