fix: convert pandas Timestamp to Snowflake-compatible string in write_pandas (closes #991) - #4316
Open
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
botbikamordehai2-sketch
requested review from
sfc-gh-bkogan,
sfc-gh-jzeng and
sfc-gh-yuwang
August 15, 2026 09:27
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When writing a pandas DataFrame with a datetime64[ns] column to Snowflake using
write_pandas, the generated SQL includes timestamps in a format that Snowflake interprets as an invalid date (e.g., '2013-02-10 00:00:00' may be misformatted or include microseconds/timezone that Snowflake cannot parse). The issue is in_extract_schema_and_data_from_pandas_dfwhere Timestamp objects are converted to strings without explicit formatting, causing invalid date errors.Fix
In the
_extract_schema_and_data_from_pandas_dffunction, when handlingpd.Timestampvalues, convert them to a string in the ISO 8601 format'%Y-%m-%d %H:%M:%S.%f'(or using'%Y-%m-%d %H:%M:%S'for non-microsecond) which is a valid Snowflake timestamp literal. For timezone-aware timestamps, first normalize to UTC and then remove the timezone to align with Snowflake's default behavior of ignoring timezone offsets. This ensures thatwrite_pandasgenerates safe SQL literals that Snowflake can parse.Closes #991