fix: NumPy 2.0 shim before spycy import in cypher tool - #28
Open
villelaitila wants to merge 1 commit into
Open
villelaitila wants to merge 1 commit into
villelaitila wants to merge 1 commit into
Conversation
spycy <= 0.0.3 references np.float_ (removed in NumPy 2.0), so sgraph_cypher_query crashes on toInteger/toFloat/toString. Restore the alias before importing sgraph.cypher/spycy; no-op on NumPy 1.x. Remove once sgraph ships softagram/sgraph#191 or spycy releases aneeshdurg/spycy#3.
Softagram Impact Report for pull/28 (head commit: 59d67a1)TL;DR Arch. Impact: 📉 -2 | Changed code files: 1 | Directly impacted code files: 3
New dependencies 😳
Regular new dependencies: 1 | Regular removed deps: 0 ⭐ Change Overview
🤖 AGENTS - machine-readable impact data (1 files changed, 3 impacted, +2/-0 deps)Change overviewHead Added dependencies (2)
Removed dependencies (0)None. Impacted files (3)Unchanged files that directly depend on files changed in this PR - check them for behavioral impact. Grouped by changed file:
Complete data
[] 📄 Full report
Impact Report explained. Give feedback on this report to support@softagram.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sgraph_cypher_querycrashes withAttributeError: np.float_ was removed in the NumPy 2.0 releasewhenever a query usestoInteger/toFloat/toString— spycy <= 0.0.3 still references the removed alias and this venv runs NumPy 2.x.np.float_ = np.float64, identical object on NumPy 1.x) right before thesgraph.cypherimport in the tool. Marked for removal once sgraph ships fix: NumPy 2.0 compat shim for spycy in cypher module sgraph#191 (library-level shim) or a spycy release containing fix: NumPy 2.0 compatibility — replace removed np.float_ with np.float64 aneeshdurg/spycy#3 is required.Test Plan