Skip to content

refactor: 코딩 컨벤션 관련 리팩터링#712

Merged
whqtker merged 5 commits intodevelopfrom
refactor/381-coding-convention
May 5, 2026
Merged

refactor: 코딩 컨벤션 관련 리팩터링#712
whqtker merged 5 commits intodevelopfrom
refactor/381-coding-convention

Conversation

@whqtker
Copy link
Copy Markdown
Member

@whqtker whqtker commented May 1, 2026

관련 이슈

작업 내용

특이 사항

  1. docs/code-style/solid-connection-intellij-scheme.xml 기반으로 리포매팅
  2. 모든 엔티티 컬럼에 name 옵션 추가
  3. primitive type에는 명시적으로 @Column(nullable = false) 추가
  4. default값이 존재하는 필드는 @ColumnDefault 로 값 초기화

리뷰 요구사항 (선택)

@whqtker whqtker self-assigned this May 1, 2026
@whqtker whqtker marked this pull request as ready for review May 1, 2026 13:47
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

이 변경사항은 프로젝트 전반에 걸친 대규모 코드 정리 및 표준화 작업입니다. 주요 구성은 다음과 같습니다:

  1. JPA 엔티티 매핑 정규화 — 약 50개 이상의 도메인 및 DTO 클래스에서 @Column(name="...") 명시, @ColumnDefault 추가, nullable=false 제약 추가로 ORM 매핑 명확화
  2. 데이터베이스 기본값 정의 — Hibernate @ColumnDefault 어노테이션 도입으로 DB 레벨 기본값 설정 (예: boolean default false, PENDING 상태)
  3. 포맷팅 및 코드 스타일 통일 — import 순서 정렬, 공백 정규화, 들여쓰기 개선, 메서드/필드 선언 순서 정리
  4. 테스트 코드 개선 — 테스트 클래스 내 필드 및 헬퍼 메서드 위치 조정, 중복 코드 제거
  5. 마이너 기능 추가TokenProperties에 헬퍼 메서드 2개 추가, RequestContext 신규 클래스 도입
  6. 설정 파일 재정렬 — logback-spring.xml, data.sql 등의 구조 개선

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~40 minutes

Suggested reviewers

  • wibaek
  • Hexeong
  • JAEHEE25
  • lsy1307
  • sukangpunch
  • Gyuhyeok99
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/381-coding-convention

Copy link
Copy Markdown
Contributor

@sukangpunch sukangpunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@sukangpunch
Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 165 files, which is 15 over the limit of 150.

⚙️ Run configuration
Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 96886132-e448-40e0-a55b-1e4eaea8870e

📥 Commits
Reviewing files that changed from the base of the PR and between be3c6c7 and e00629b.

📒 Files selected for processing (165)

  • .claude/skills/review-pr/SKILL.md
  • .claude/skills/test/SKILL.md
  • .github/ISSUE_TEMPLATE/bug_report.md
  • .github/ISSUE_TEMPLATE/refactor_request.md
  • .github/workflows/prod-cd.yml
  • .serena/project.yml
  • claude.md
  • docs/code-style/solid-connection-intellij-scheme.xml
  • src/main/java/com/example/solidconnection/admin/controller/AdminMentorApplicationController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserBanController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserController.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MatchedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MenteeInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MentorInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UnivApplyInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserBanRequest.java
  • src/main/java/com/example/solidconnection/admin/dto/UserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/location/country/controller/AdminCountryController.java
  • src/main/java/com/example/solidconnection/admin/location/country/service/AdminCountryService.java
  • src/main/java/com/example/solidconnection/admin/service/AdminUserService.java
  • src/main/java/com/example/solidconnection/application/domain/Application.java
  • src/main/java/com/example/solidconnection/auth/dto/SignUpRequest.java
  • src/main/java/com/example/solidconnection/auth/dto/oauth/KakaoUserInfoDto.java
  • src/main/java/com/example/solidconnection/auth/token/config/TokenProperties.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatAttachment.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatMessage.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatParticipant.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatReadStatus.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatRoom.java
  • src/main/java/com/example/solidconnection/chat/repository/ChatMessageRepository.java
  • src/main/java/com/example/solidconnection/common/BaseEntity.java
  • src/main/java/com/example/solidconnection/common/config/datasource/DataSourceProxyConfig.java
  • src/main/java/com/example/solidconnection/common/config/web/WebMvcConfig.java
  • src/main/java/com/example/solidconnection/common/constant/FileConstants.java
  • src/main/java/com/example/solidconnection/common/exception/ErrorCode.java
  • src/main/java/com/example/solidconnection/common/filter/HttpLoggingFilter.java
  • src/main/java/com/example/solidconnection/common/interceptor/ApiPerformanceInterceptor.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContext.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContextHolder.java
  • src/main/java/com/example/solidconnection/common/listener/QueryMetricsListener.java
  • src/main/java/com/example/solidconnection/community/board/domain/Board.java
  • src/main/java/com/example/solidconnection/community/comment/domain/Comment.java
  • src/main/java/com/example/solidconnection/community/post/domain/Post.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostCategory.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostImage.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostLike.java
  • src/main/java/com/example/solidconnection/community/post/repository/PostRepository.java
  • src/main/java/com/example/solidconnection/community/post/service/UpdateViewCountService.java
  • src/main/java/com/example/solidconnection/location/country/domain/Country.java
  • src/main/java/com/example/solidconnection/location/country/domain/InterestedCountry.java
  • src/main/java/com/example/solidconnection/location/region/domain/InterestedRegion.java
  • src/main/java/com/example/solidconnection/location/region/domain/Region.java
  • src/main/java/com/example/solidconnection/mentor/controller/MentorController.java
  • src/main/java/com/example/solidconnection/mentor/domain/Channel.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentor.java
  • src/main/java/com/example/solidconnection/mentor/domain/MentorApplication.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentoring.java
  • src/main/java/com/example/solidconnection/mentor/dto/MentorApplicationRequest.java
  • src/main/java/com/example/solidconnection/mentor/repository/MentorApplicationRepository.java
  • src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java
  • src/main/java/com/example/solidconnection/news/domain/LikedNews.java
  • src/main/java/com/example/solidconnection/news/domain/News.java
  • src/main/java/com/example/solidconnection/report/domain/Report.java
  • src/main/java/com/example/solidconnection/report/domain/TargetType.java
  • src/main/java/com/example/solidconnection/report/repository/ReportRepository.java
  • src/main/java/com/example/solidconnection/s3/domain/UploadPath.java
  • src/main/java/com/example/solidconnection/score/domain/GpaScore.java
  • src/main/java/com/example/solidconnection/score/domain/LanguageTestScore.java
  • src/main/java/com/example/solidconnection/score/repository/custom/GpaScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/score/repository/custom/LanguageTestScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/domain/SiteUser.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBan.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBlock.java
  • src/main/java/com/example/solidconnection/siteuser/dto/MyPageResponse.java
  • src/main/java/com/example/solidconnection/siteuser/repository/SiteUserRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/service/MyPageService.java
  • src/main/java/com/example/solidconnection/term/domain/Term.java
  • src/main/java/com/example/solidconnection/university/domain/HomeUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/HostUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/LanguageRequirement.java
  • src/main/java/com/example/solidconnection/university/domain/LikedUnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/domain/UnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/university/service/GeneralUnivApplyInfoRecommendService.java
  • src/main/java/com/example/solidconnection/university/service/UnivApplyInfoRecommendService.java
  • src/main/resources/data.sql
  • src/main/resources/db/migration/V11__remove_siteuser_birth_and_gender.sql
  • src/main/resources/db/migration/V12__create_news.sql
  • src/main/resources/db/migration/V13__add_application_index_and_delete_manny_to_one_mapping.sql
  • src/main/resources/db/migration/V14__set_unique_constraint_to_nickname.sql
  • src/main/resources/db/migration/V15__add_unique_constraint_to_liked_university.sql
  • src/main/resources/db/migration/V16__add_unique_constraint_to_intersted.sql
  • src/main/resources/db/migration/V19__create_mentor_related_tables.sql
  • src/main/resources/db/migration/V1__init.sql
  • src/main/resources/db/migration/V21__create_liked_news_table.sql
  • src/main/resources/db/migration/V23__drop_mentoring_reject_reason_column.sql
  • src/main/resources/db/migration/V24__add_chat_related_tables.sql
  • src/main/resources/db/migration/V29__alter_mentor_introduction_pass_tip_not_null.sql
  • src/main/resources/db/migration/V2__add_gpa_score_and_language_test_score.sql
  • src/main/resources/db/migration/V30__modify_verify_status_from_varchar_to_enum.sql
  • src/main/resources/db/migration/V32__add_user_block_table.sql
  • src/main/resources/db/migration/V35__add_mentor_application_table.sql
  • src/main/resources/db/migration/V36__migrate_term_to_table.sql
  • src/main/resources/db/migration/V37__add_unique_constraint_to_mentor_id_mentee_id.sql
  • src/main/resources/db/migration/V38__add_term_id_to_mentor_application.sql
  • src/main/resources/db/migration/V3__add_auth_type_column_and_unique_key.sql
  • src/main/resources/db/migration/V40__create_user_ban_table.sql
  • src/main/resources/db/migration/V41__add_is_deleted_to_post_and_chat_message.sql
  • src/main/resources/db/migration/V42__rename_university_to_host_university_and_create_home_university.sql
  • src/main/resources/db/migration/V43__move_home_university_fk_to_univ_apply_info.sql
  • src/main/resources/db/migration/V45__modify_mentor_introduction_pass_tip_nullable.sql
  • src/main/resources/db/migration/V4__remove_issue_date_columns.sql
  • src/main/resources/db/migration/V5__add_password_column.sql
  • src/main/resources/db/migration/V7__expand_details_column_length.sql
  • src/main/resources/db/migration/V8__add_two_semester_to_semeter_avaliable_enum.sql
  • src/main/resources/logback-spring.xml
  • src/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java
  • src/test/java/com/example/solidconnection/admin/service/AdminUserServiceTest.java
  • src/test/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManagerTest.java
  • src/test/java/com/example/solidconnection/auth/service/AuthTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/JwtTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/oauth/OAuthServiceTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/PasswordTemporaryStorageTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/SignUpTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/token/RedisTokenStorageTest.java
  • src/test/java/com/example/solidconnection/chat/service/ChatServiceTest.java
  • src/test/java/com/example/solidconnection/common/filter/HttpLoggingFilterTest.java
  • src/test/java/com/example/solidconnection/common/interceptor/BannedUserInterceptorTest.java
  • src/test/java/com/example/solidconnection/common/resolver/AuthorizedUserResolverTest.java
  • src/test/java/com/example/solidconnection/common/resolver/CustomPageableHandlerMethodArgumentResolverTest.java
  • src/test/java/com/example/solidconnection/community/post/service/PostCommandServiceTest.java
  • src/test/java/com/example/solidconnection/database/FlywayMigrationTest.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixture.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixtureBuilder.java
  • src/test/java/com/example/solidconnection/mentor/service/MentorApplicationServiceTest.java
  • src/test/java/com/example/solidconnection/mentor/service/MentoringCommandServiceTest.java
  • src/test/java/com/example/solidconnection/news/service/NewsCommandServiceTest.java
  • src/test/java/com/example/solidconnection/report/fixture/ReportFixtureBuilder.java
  • src/test/java/com/example/solidconnection/s3/service/S3ServiceTest.java
  • src/test/java/com/example/solidconnection/score/service/ScoreServiceTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationProviderTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationTest.java
  • src/test/java/com/example/solidconnection/security/filter/ExceptionHandlerFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/SignOutCheckFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/TokenAuthenticationFilterTest.java
  • src/test/java/com/example/solidconnection/security/userdetails/SiteUserDetailsServiceTest.java
  • src/test/java/com/example/solidconnection/siteuser/fixture/UserBanFixture.java
  • src/test/java/com/example/solidconnection/siteuser/repository/SiteUserRepositoryTest.java
  • src/test/java/com/example/solidconnection/siteuser/service/MyPageServiceTest.java
  • src/test/java/com/example/solidconnection/university/repository/HostUniversityRepositoryForTest.java
  • src/test/java/com/example/solidconnection/university/repository/LikedUnivApplyInfoRepositoryTest.java
  • src/test/java/com/example/solidconnection/university/service/LikedUnivApplyInfoServiceTest.java
  • src/test/java/com/example/solidconnection/university/service/UnivApplyInfoQueryServiceTest.java
  • src/test/resources/application.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

✨ Finishing Touches
🧪 Generate unit tests (beta)

  • Create PR with unit tests
  • Commit unit tests in branch refactor/381-coding-convention

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Important

Review skipped

Too many files!

This PR contains 165 files, which is 15 over the limit of 150.

⚙️ Run configuration
Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 96886132-e448-40e0-a55b-1e4eaea8870e

📥 Commits
Reviewing files that changed from the base of the PR and between be3c6c7 and e00629b.

📒 Files selected for processing (165)

  • .claude/skills/review-pr/SKILL.md
  • .claude/skills/test/SKILL.md
  • .github/ISSUE_TEMPLATE/bug_report.md
  • .github/ISSUE_TEMPLATE/refactor_request.md
  • .github/workflows/prod-cd.yml
  • .serena/project.yml
  • claude.md
  • docs/code-style/solid-connection-intellij-scheme.xml
  • src/main/java/com/example/solidconnection/admin/controller/AdminMentorApplicationController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserBanController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserController.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MatchedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MenteeInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MentorInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UnivApplyInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserBanRequest.java
  • src/main/java/com/example/solidconnection/admin/dto/UserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/location/country/controller/AdminCountryController.java
  • src/main/java/com/example/solidconnection/admin/location/country/service/AdminCountryService.java
  • src/main/java/com/example/solidconnection/admin/service/AdminUserService.java
  • src/main/java/com/example/solidconnection/application/domain/Application.java
  • src/main/java/com/example/solidconnection/auth/dto/SignUpRequest.java
  • src/main/java/com/example/solidconnection/auth/dto/oauth/KakaoUserInfoDto.java
  • src/main/java/com/example/solidconnection/auth/token/config/TokenProperties.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatAttachment.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatMessage.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatParticipant.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatReadStatus.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatRoom.java
  • src/main/java/com/example/solidconnection/chat/repository/ChatMessageRepository.java
  • src/main/java/com/example/solidconnection/common/BaseEntity.java
  • src/main/java/com/example/solidconnection/common/config/datasource/DataSourceProxyConfig.java
  • src/main/java/com/example/solidconnection/common/config/web/WebMvcConfig.java
  • src/main/java/com/example/solidconnection/common/constant/FileConstants.java
  • src/main/java/com/example/solidconnection/common/exception/ErrorCode.java
  • src/main/java/com/example/solidconnection/common/filter/HttpLoggingFilter.java
  • src/main/java/com/example/solidconnection/common/interceptor/ApiPerformanceInterceptor.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContext.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContextHolder.java
  • src/main/java/com/example/solidconnection/common/listener/QueryMetricsListener.java
  • src/main/java/com/example/solidconnection/community/board/domain/Board.java
  • src/main/java/com/example/solidconnection/community/comment/domain/Comment.java
  • src/main/java/com/example/solidconnection/community/post/domain/Post.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostCategory.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostImage.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostLike.java
  • src/main/java/com/example/solidconnection/community/post/repository/PostRepository.java
  • src/main/java/com/example/solidconnection/community/post/service/UpdateViewCountService.java
  • src/main/java/com/example/solidconnection/location/country/domain/Country.java
  • src/main/java/com/example/solidconnection/location/country/domain/InterestedCountry.java
  • src/main/java/com/example/solidconnection/location/region/domain/InterestedRegion.java
  • src/main/java/com/example/solidconnection/location/region/domain/Region.java
  • src/main/java/com/example/solidconnection/mentor/controller/MentorController.java
  • src/main/java/com/example/solidconnection/mentor/domain/Channel.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentor.java
  • src/main/java/com/example/solidconnection/mentor/domain/MentorApplication.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentoring.java
  • src/main/java/com/example/solidconnection/mentor/dto/MentorApplicationRequest.java
  • src/main/java/com/example/solidconnection/mentor/repository/MentorApplicationRepository.java
  • src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java
  • src/main/java/com/example/solidconnection/news/domain/LikedNews.java
  • src/main/java/com/example/solidconnection/news/domain/News.java
  • src/main/java/com/example/solidconnection/report/domain/Report.java
  • src/main/java/com/example/solidconnection/report/domain/TargetType.java
  • src/main/java/com/example/solidconnection/report/repository/ReportRepository.java
  • src/main/java/com/example/solidconnection/s3/domain/UploadPath.java
  • src/main/java/com/example/solidconnection/score/domain/GpaScore.java
  • src/main/java/com/example/solidconnection/score/domain/LanguageTestScore.java
  • src/main/java/com/example/solidconnection/score/repository/custom/GpaScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/score/repository/custom/LanguageTestScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/domain/SiteUser.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBan.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBlock.java
  • src/main/java/com/example/solidconnection/siteuser/dto/MyPageResponse.java
  • src/main/java/com/example/solidconnection/siteuser/repository/SiteUserRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/service/MyPageService.java
  • src/main/java/com/example/solidconnection/term/domain/Term.java
  • src/main/java/com/example/solidconnection/university/domain/HomeUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/HostUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/LanguageRequirement.java
  • src/main/java/com/example/solidconnection/university/domain/LikedUnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/domain/UnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/university/service/GeneralUnivApplyInfoRecommendService.java
  • src/main/java/com/example/solidconnection/university/service/UnivApplyInfoRecommendService.java
  • src/main/resources/data.sql
  • src/main/resources/db/migration/V11__remove_siteuser_birth_and_gender.sql
  • src/main/resources/db/migration/V12__create_news.sql
  • src/main/resources/db/migration/V13__add_application_index_and_delete_manny_to_one_mapping.sql
  • src/main/resources/db/migration/V14__set_unique_constraint_to_nickname.sql
  • src/main/resources/db/migration/V15__add_unique_constraint_to_liked_university.sql
  • src/main/resources/db/migration/V16__add_unique_constraint_to_intersted.sql
  • src/main/resources/db/migration/V19__create_mentor_related_tables.sql
  • src/main/resources/db/migration/V1__init.sql
  • src/main/resources/db/migration/V21__create_liked_news_table.sql
  • src/main/resources/db/migration/V23__drop_mentoring_reject_reason_column.sql
  • src/main/resources/db/migration/V24__add_chat_related_tables.sql
  • src/main/resources/db/migration/V29__alter_mentor_introduction_pass_tip_not_null.sql
  • src/main/resources/db/migration/V2__add_gpa_score_and_language_test_score.sql
  • src/main/resources/db/migration/V30__modify_verify_status_from_varchar_to_enum.sql
  • src/main/resources/db/migration/V32__add_user_block_table.sql
  • src/main/resources/db/migration/V35__add_mentor_application_table.sql
  • src/main/resources/db/migration/V36__migrate_term_to_table.sql
  • src/main/resources/db/migration/V37__add_unique_constraint_to_mentor_id_mentee_id.sql
  • src/main/resources/db/migration/V38__add_term_id_to_mentor_application.sql
  • src/main/resources/db/migration/V3__add_auth_type_column_and_unique_key.sql
  • src/main/resources/db/migration/V40__create_user_ban_table.sql
  • src/main/resources/db/migration/V41__add_is_deleted_to_post_and_chat_message.sql
  • src/main/resources/db/migration/V42__rename_university_to_host_university_and_create_home_university.sql
  • src/main/resources/db/migration/V43__move_home_university_fk_to_univ_apply_info.sql
  • src/main/resources/db/migration/V45__modify_mentor_introduction_pass_tip_nullable.sql
  • src/main/resources/db/migration/V4__remove_issue_date_columns.sql
  • src/main/resources/db/migration/V5__add_password_column.sql
  • src/main/resources/db/migration/V7__expand_details_column_length.sql
  • src/main/resources/db/migration/V8__add_two_semester_to_semeter_avaliable_enum.sql
  • src/main/resources/logback-spring.xml
  • src/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java
  • src/test/java/com/example/solidconnection/admin/service/AdminUserServiceTest.java
  • src/test/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManagerTest.java
  • src/test/java/com/example/solidconnection/auth/service/AuthTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/JwtTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/oauth/OAuthServiceTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/PasswordTemporaryStorageTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/SignUpTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/token/RedisTokenStorageTest.java
  • src/test/java/com/example/solidconnection/chat/service/ChatServiceTest.java
  • src/test/java/com/example/solidconnection/common/filter/HttpLoggingFilterTest.java
  • src/test/java/com/example/solidconnection/common/interceptor/BannedUserInterceptorTest.java
  • src/test/java/com/example/solidconnection/common/resolver/AuthorizedUserResolverTest.java
  • src/test/java/com/example/solidconnection/common/resolver/CustomPageableHandlerMethodArgumentResolverTest.java
  • src/test/java/com/example/solidconnection/community/post/service/PostCommandServiceTest.java
  • src/test/java/com/example/solidconnection/database/FlywayMigrationTest.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixture.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixtureBuilder.java
  • src/test/java/com/example/solidconnection/mentor/service/MentorApplicationServiceTest.java
  • src/test/java/com/example/solidconnection/mentor/service/MentoringCommandServiceTest.java
  • src/test/java/com/example/solidconnection/news/service/NewsCommandServiceTest.java
  • src/test/java/com/example/solidconnection/report/fixture/ReportFixtureBuilder.java
  • src/test/java/com/example/solidconnection/s3/service/S3ServiceTest.java
  • src/test/java/com/example/solidconnection/score/service/ScoreServiceTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationProviderTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationTest.java
  • src/test/java/com/example/solidconnection/security/filter/ExceptionHandlerFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/SignOutCheckFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/TokenAuthenticationFilterTest.java
  • src/test/java/com/example/solidconnection/security/userdetails/SiteUserDetailsServiceTest.java
  • src/test/java/com/example/solidconnection/siteuser/fixture/UserBanFixture.java
  • src/test/java/com/example/solidconnection/siteuser/repository/SiteUserRepositoryTest.java
  • src/test/java/com/example/solidconnection/siteuser/service/MyPageServiceTest.java
  • src/test/java/com/example/solidconnection/university/repository/HostUniversityRepositoryForTest.java
  • src/test/java/com/example/solidconnection/university/repository/LikedUnivApplyInfoRepositoryTest.java
  • src/test/java/com/example/solidconnection/university/service/LikedUnivApplyInfoServiceTest.java
  • src/test/java/com/example/solidconnection/university/service/UnivApplyInfoQueryServiceTest.java
  • src/test/resources/application.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

✨ Finishing Touches
🧪 Generate unit tests (beta)

  • Create PR with unit tests
  • Commit unit tests in branch refactor/381-coding-convention

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai 변경 사항들을 요약해줘

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Tip

For best results, initiate chat on the files or code changes.

@sukangpunch 안녕하세요! 😊 이 PR의 변경 사항을 요약해 드릴게요.


📋 PR #712 변경 사항 요약 — refactor: 코딩 컨벤션 관련 리팩터링

관련 이슈: #381 · 변경 파일: 총 165개


1. 🎨 전체 코드 리포매팅

  • docs/code-style/solid-connection-intellij-scheme.xml 기반으로 프로젝트 전체 코드를 일괄 재포맷했습니다.
  • 들여쓰기, 줄 바꿈, 공백 등 코드 스타일이 통일되었습니다.

2. 🏷️ 엔티티 컬럼에 name 옵션 추가

  • 모든 JPA 엔티티의 @Column 어노테이션에 name 속성을 명시적으로 추가했습니다.
    • 예: @Column@Column(name = "column_name")
  • 영향 파일: SiteUser, Post, Comment, ChatMessage, Mentor, Application 등 전체 도메인 엔티티

3. 🔒 Primitive 타입 필드에 nullable = false 명시

  • int, long, boolean 등 primitive 타입을 가진 모든 컬럼에 @Column(nullable = false)를 명시적으로 추가했습니다.
    • primitive 타입은 원래 null이 될 수 없으나, DB 스키마 명확성을 위해 어노테이션으로도 표현했습니다.

4. 📌 Default 값 필드에 @ColumnDefault 추가

  • 기본값이 있는 필드는 @ColumnDefault 어노테이션으로 값을 명시적으로 초기화했습니다.
    • 예: isDeleted, viewCount 등 기본값이 false 또는 0인 필드

📁 주요 변경 파일 분류

카테고리 주요 파일
엔티티 도메인 SiteUser, Post, Comment, ChatRoom, Mentor, Application, GpaScore
DTO MyPageResponse, UnivApplyInfoDetailResponse
서비스 / 레포지토리 AdminUserService, MentorApplicationService, SiteUserFilterRepositoryImpl
DB 마이그레이션 (Flyway) V1__init.sql ~ V45__...sql (포맷 정리)
설정 파일 .github/workflows/prod-cd.yml, logback-spring.xml, .serena/project.yml
테스트 코드 전체 테스트 클래스 일괄 리포맷

ℹ️ 이 PR은 기능 변경 없이 코딩 컨벤션 통일을 목적으로 한 순수 리팩터링입니다. 리뷰 시 로직보다는 어노테이션 일관성 위주로 확인하시면 될 것 같습니다! 😊

@whqtker
Copy link
Copy Markdown
Member Author

whqtker commented May 2, 2026

Important

Review skipped

Too many files!
This PR contains 165 files, which is 15 over the limit of 150.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 96886132-e448-40e0-a55b-1e4eaea8870e
📥 Commits
Reviewing files that changed from the base of the PR and between be3c6c7 and e00629b.
📒 Files selected for processing (165)

  • .claude/skills/review-pr/SKILL.md
  • .claude/skills/test/SKILL.md
  • .github/ISSUE_TEMPLATE/bug_report.md
  • .github/ISSUE_TEMPLATE/refactor_request.md
  • .github/workflows/prod-cd.yml
  • .serena/project.yml
  • claude.md
  • docs/code-style/solid-connection-intellij-scheme.xml
  • src/main/java/com/example/solidconnection/admin/controller/AdminMentorApplicationController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserBanController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserController.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MatchedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MenteeInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MentorInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UnivApplyInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserBanRequest.java
  • src/main/java/com/example/solidconnection/admin/dto/UserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/location/country/controller/AdminCountryController.java
  • src/main/java/com/example/solidconnection/admin/location/country/service/AdminCountryService.java
  • src/main/java/com/example/solidconnection/admin/service/AdminUserService.java
  • src/main/java/com/example/solidconnection/application/domain/Application.java
  • src/main/java/com/example/solidconnection/auth/dto/SignUpRequest.java
  • src/main/java/com/example/solidconnection/auth/dto/oauth/KakaoUserInfoDto.java
  • src/main/java/com/example/solidconnection/auth/token/config/TokenProperties.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatAttachment.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatMessage.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatParticipant.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatReadStatus.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatRoom.java
  • src/main/java/com/example/solidconnection/chat/repository/ChatMessageRepository.java
  • src/main/java/com/example/solidconnection/common/BaseEntity.java
  • src/main/java/com/example/solidconnection/common/config/datasource/DataSourceProxyConfig.java
  • src/main/java/com/example/solidconnection/common/config/web/WebMvcConfig.java
  • src/main/java/com/example/solidconnection/common/constant/FileConstants.java
  • src/main/java/com/example/solidconnection/common/exception/ErrorCode.java
  • src/main/java/com/example/solidconnection/common/filter/HttpLoggingFilter.java
  • src/main/java/com/example/solidconnection/common/interceptor/ApiPerformanceInterceptor.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContext.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContextHolder.java
  • src/main/java/com/example/solidconnection/common/listener/QueryMetricsListener.java
  • src/main/java/com/example/solidconnection/community/board/domain/Board.java
  • src/main/java/com/example/solidconnection/community/comment/domain/Comment.java
  • src/main/java/com/example/solidconnection/community/post/domain/Post.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostCategory.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostImage.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostLike.java
  • src/main/java/com/example/solidconnection/community/post/repository/PostRepository.java
  • src/main/java/com/example/solidconnection/community/post/service/UpdateViewCountService.java
  • src/main/java/com/example/solidconnection/location/country/domain/Country.java
  • src/main/java/com/example/solidconnection/location/country/domain/InterestedCountry.java
  • src/main/java/com/example/solidconnection/location/region/domain/InterestedRegion.java
  • src/main/java/com/example/solidconnection/location/region/domain/Region.java
  • src/main/java/com/example/solidconnection/mentor/controller/MentorController.java
  • src/main/java/com/example/solidconnection/mentor/domain/Channel.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentor.java
  • src/main/java/com/example/solidconnection/mentor/domain/MentorApplication.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentoring.java
  • src/main/java/com/example/solidconnection/mentor/dto/MentorApplicationRequest.java
  • src/main/java/com/example/solidconnection/mentor/repository/MentorApplicationRepository.java
  • src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java
  • src/main/java/com/example/solidconnection/news/domain/LikedNews.java
  • src/main/java/com/example/solidconnection/news/domain/News.java
  • src/main/java/com/example/solidconnection/report/domain/Report.java
  • src/main/java/com/example/solidconnection/report/domain/TargetType.java
  • src/main/java/com/example/solidconnection/report/repository/ReportRepository.java
  • src/main/java/com/example/solidconnection/s3/domain/UploadPath.java
  • src/main/java/com/example/solidconnection/score/domain/GpaScore.java
  • src/main/java/com/example/solidconnection/score/domain/LanguageTestScore.java
  • src/main/java/com/example/solidconnection/score/repository/custom/GpaScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/score/repository/custom/LanguageTestScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/domain/SiteUser.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBan.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBlock.java
  • src/main/java/com/example/solidconnection/siteuser/dto/MyPageResponse.java
  • src/main/java/com/example/solidconnection/siteuser/repository/SiteUserRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/service/MyPageService.java
  • src/main/java/com/example/solidconnection/term/domain/Term.java
  • src/main/java/com/example/solidconnection/university/domain/HomeUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/HostUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/LanguageRequirement.java
  • src/main/java/com/example/solidconnection/university/domain/LikedUnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/domain/UnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/university/service/GeneralUnivApplyInfoRecommendService.java
  • src/main/java/com/example/solidconnection/university/service/UnivApplyInfoRecommendService.java
  • src/main/resources/data.sql
  • src/main/resources/db/migration/V11__remove_siteuser_birth_and_gender.sql
  • src/main/resources/db/migration/V12__create_news.sql
  • src/main/resources/db/migration/V13__add_application_index_and_delete_manny_to_one_mapping.sql
  • src/main/resources/db/migration/V14__set_unique_constraint_to_nickname.sql
  • src/main/resources/db/migration/V15__add_unique_constraint_to_liked_university.sql
  • src/main/resources/db/migration/V16__add_unique_constraint_to_intersted.sql
  • src/main/resources/db/migration/V19__create_mentor_related_tables.sql
  • src/main/resources/db/migration/V1__init.sql
  • src/main/resources/db/migration/V21__create_liked_news_table.sql
  • src/main/resources/db/migration/V23__drop_mentoring_reject_reason_column.sql
  • src/main/resources/db/migration/V24__add_chat_related_tables.sql
  • src/main/resources/db/migration/V29__alter_mentor_introduction_pass_tip_not_null.sql
  • src/main/resources/db/migration/V2__add_gpa_score_and_language_test_score.sql
  • src/main/resources/db/migration/V30__modify_verify_status_from_varchar_to_enum.sql
  • src/main/resources/db/migration/V32__add_user_block_table.sql
  • src/main/resources/db/migration/V35__add_mentor_application_table.sql
  • src/main/resources/db/migration/V36__migrate_term_to_table.sql
  • src/main/resources/db/migration/V37__add_unique_constraint_to_mentor_id_mentee_id.sql
  • src/main/resources/db/migration/V38__add_term_id_to_mentor_application.sql
  • src/main/resources/db/migration/V3__add_auth_type_column_and_unique_key.sql
  • src/main/resources/db/migration/V40__create_user_ban_table.sql
  • src/main/resources/db/migration/V41__add_is_deleted_to_post_and_chat_message.sql
  • src/main/resources/db/migration/V42__rename_university_to_host_university_and_create_home_university.sql
  • src/main/resources/db/migration/V43__move_home_university_fk_to_univ_apply_info.sql
  • src/main/resources/db/migration/V45__modify_mentor_introduction_pass_tip_nullable.sql
  • src/main/resources/db/migration/V4__remove_issue_date_columns.sql
  • src/main/resources/db/migration/V5__add_password_column.sql
  • src/main/resources/db/migration/V7__expand_details_column_length.sql
  • src/main/resources/db/migration/V8__add_two_semester_to_semeter_avaliable_enum.sql
  • src/main/resources/logback-spring.xml
  • src/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java
  • src/test/java/com/example/solidconnection/admin/service/AdminUserServiceTest.java
  • src/test/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManagerTest.java
  • src/test/java/com/example/solidconnection/auth/service/AuthTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/JwtTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/oauth/OAuthServiceTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/PasswordTemporaryStorageTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/SignUpTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/token/RedisTokenStorageTest.java
  • src/test/java/com/example/solidconnection/chat/service/ChatServiceTest.java
  • src/test/java/com/example/solidconnection/common/filter/HttpLoggingFilterTest.java
  • src/test/java/com/example/solidconnection/common/interceptor/BannedUserInterceptorTest.java
  • src/test/java/com/example/solidconnection/common/resolver/AuthorizedUserResolverTest.java
  • src/test/java/com/example/solidconnection/common/resolver/CustomPageableHandlerMethodArgumentResolverTest.java
  • src/test/java/com/example/solidconnection/community/post/service/PostCommandServiceTest.java
  • src/test/java/com/example/solidconnection/database/FlywayMigrationTest.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixture.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixtureBuilder.java
  • src/test/java/com/example/solidconnection/mentor/service/MentorApplicationServiceTest.java
  • src/test/java/com/example/solidconnection/mentor/service/MentoringCommandServiceTest.java
  • src/test/java/com/example/solidconnection/news/service/NewsCommandServiceTest.java
  • src/test/java/com/example/solidconnection/report/fixture/ReportFixtureBuilder.java
  • src/test/java/com/example/solidconnection/s3/service/S3ServiceTest.java
  • src/test/java/com/example/solidconnection/score/service/ScoreServiceTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationProviderTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationTest.java
  • src/test/java/com/example/solidconnection/security/filter/ExceptionHandlerFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/SignOutCheckFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/TokenAuthenticationFilterTest.java
  • src/test/java/com/example/solidconnection/security/userdetails/SiteUserDetailsServiceTest.java
  • src/test/java/com/example/solidconnection/siteuser/fixture/UserBanFixture.java
  • src/test/java/com/example/solidconnection/siteuser/repository/SiteUserRepositoryTest.java
  • src/test/java/com/example/solidconnection/siteuser/service/MyPageServiceTest.java
  • src/test/java/com/example/solidconnection/university/repository/HostUniversityRepositoryForTest.java
  • src/test/java/com/example/solidconnection/university/repository/LikedUnivApplyInfoRepositoryTest.java
  • src/test/java/com/example/solidconnection/university/service/LikedUnivApplyInfoServiceTest.java
  • src/test/java/com/example/solidconnection/university/service/UnivApplyInfoQueryServiceTest.java
  • src/test/resources/application.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:

  • 🔍 Trigger review

✨ Finishing Touches
🧪 Generate unit tests (beta)

  • Create PR with unit tests
  • Commit unit tests in branch refactor/381-coding-convention

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Important

Review skipped

Too many files!
This PR contains 165 files, which is 15 over the limit of 150.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 96886132-e448-40e0-a55b-1e4eaea8870e
📥 Commits
Reviewing files that changed from the base of the PR and between be3c6c7 and e00629b.
📒 Files selected for processing (165)

  • .claude/skills/review-pr/SKILL.md
  • .claude/skills/test/SKILL.md
  • .github/ISSUE_TEMPLATE/bug_report.md
  • .github/ISSUE_TEMPLATE/refactor_request.md
  • .github/workflows/prod-cd.yml
  • .serena/project.yml
  • claude.md
  • docs/code-style/solid-connection-intellij-scheme.xml
  • src/main/java/com/example/solidconnection/admin/controller/AdminMentorApplicationController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserBanController.java
  • src/main/java/com/example/solidconnection/admin/controller/AdminUserController.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/BannedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MatchedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MenteeInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/MentorInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedHistoryResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/ReportedInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/RestrictedUserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UnivApplyInfoResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserBanRequest.java
  • src/main/java/com/example/solidconnection/admin/dto/UserInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchCondition.java
  • src/main/java/com/example/solidconnection/admin/dto/UserSearchResponse.java
  • src/main/java/com/example/solidconnection/admin/location/country/controller/AdminCountryController.java
  • src/main/java/com/example/solidconnection/admin/location/country/service/AdminCountryService.java
  • src/main/java/com/example/solidconnection/admin/service/AdminUserService.java
  • src/main/java/com/example/solidconnection/application/domain/Application.java
  • src/main/java/com/example/solidconnection/auth/dto/SignUpRequest.java
  • src/main/java/com/example/solidconnection/auth/dto/oauth/KakaoUserInfoDto.java
  • src/main/java/com/example/solidconnection/auth/token/config/TokenProperties.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatAttachment.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatMessage.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatParticipant.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatReadStatus.java
  • src/main/java/com/example/solidconnection/chat/domain/ChatRoom.java
  • src/main/java/com/example/solidconnection/chat/repository/ChatMessageRepository.java
  • src/main/java/com/example/solidconnection/common/BaseEntity.java
  • src/main/java/com/example/solidconnection/common/config/datasource/DataSourceProxyConfig.java
  • src/main/java/com/example/solidconnection/common/config/web/WebMvcConfig.java
  • src/main/java/com/example/solidconnection/common/constant/FileConstants.java
  • src/main/java/com/example/solidconnection/common/exception/ErrorCode.java
  • src/main/java/com/example/solidconnection/common/filter/HttpLoggingFilter.java
  • src/main/java/com/example/solidconnection/common/interceptor/ApiPerformanceInterceptor.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContext.java
  • src/main/java/com/example/solidconnection/common/interceptor/RequestContextHolder.java
  • src/main/java/com/example/solidconnection/common/listener/QueryMetricsListener.java
  • src/main/java/com/example/solidconnection/community/board/domain/Board.java
  • src/main/java/com/example/solidconnection/community/comment/domain/Comment.java
  • src/main/java/com/example/solidconnection/community/post/domain/Post.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostCategory.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostImage.java
  • src/main/java/com/example/solidconnection/community/post/domain/PostLike.java
  • src/main/java/com/example/solidconnection/community/post/repository/PostRepository.java
  • src/main/java/com/example/solidconnection/community/post/service/UpdateViewCountService.java
  • src/main/java/com/example/solidconnection/location/country/domain/Country.java
  • src/main/java/com/example/solidconnection/location/country/domain/InterestedCountry.java
  • src/main/java/com/example/solidconnection/location/region/domain/InterestedRegion.java
  • src/main/java/com/example/solidconnection/location/region/domain/Region.java
  • src/main/java/com/example/solidconnection/mentor/controller/MentorController.java
  • src/main/java/com/example/solidconnection/mentor/domain/Channel.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentor.java
  • src/main/java/com/example/solidconnection/mentor/domain/MentorApplication.java
  • src/main/java/com/example/solidconnection/mentor/domain/Mentoring.java
  • src/main/java/com/example/solidconnection/mentor/dto/MentorApplicationRequest.java
  • src/main/java/com/example/solidconnection/mentor/repository/MentorApplicationRepository.java
  • src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java
  • src/main/java/com/example/solidconnection/news/domain/LikedNews.java
  • src/main/java/com/example/solidconnection/news/domain/News.java
  • src/main/java/com/example/solidconnection/report/domain/Report.java
  • src/main/java/com/example/solidconnection/report/domain/TargetType.java
  • src/main/java/com/example/solidconnection/report/repository/ReportRepository.java
  • src/main/java/com/example/solidconnection/s3/domain/UploadPath.java
  • src/main/java/com/example/solidconnection/score/domain/GpaScore.java
  • src/main/java/com/example/solidconnection/score/domain/LanguageTestScore.java
  • src/main/java/com/example/solidconnection/score/repository/custom/GpaScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/score/repository/custom/LanguageTestScoreFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/domain/SiteUser.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBan.java
  • src/main/java/com/example/solidconnection/siteuser/domain/UserBlock.java
  • src/main/java/com/example/solidconnection/siteuser/dto/MyPageResponse.java
  • src/main/java/com/example/solidconnection/siteuser/repository/SiteUserRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepository.java
  • src/main/java/com/example/solidconnection/siteuser/repository/custom/SiteUserFilterRepositoryImpl.java
  • src/main/java/com/example/solidconnection/siteuser/service/MyPageService.java
  • src/main/java/com/example/solidconnection/term/domain/Term.java
  • src/main/java/com/example/solidconnection/university/domain/HomeUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/HostUniversity.java
  • src/main/java/com/example/solidconnection/university/domain/LanguageRequirement.java
  • src/main/java/com/example/solidconnection/university/domain/LikedUnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/domain/UnivApplyInfo.java
  • src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java
  • src/main/java/com/example/solidconnection/university/service/GeneralUnivApplyInfoRecommendService.java
  • src/main/java/com/example/solidconnection/university/service/UnivApplyInfoRecommendService.java
  • src/main/resources/data.sql
  • src/main/resources/db/migration/V11__remove_siteuser_birth_and_gender.sql
  • src/main/resources/db/migration/V12__create_news.sql
  • src/main/resources/db/migration/V13__add_application_index_and_delete_manny_to_one_mapping.sql
  • src/main/resources/db/migration/V14__set_unique_constraint_to_nickname.sql
  • src/main/resources/db/migration/V15__add_unique_constraint_to_liked_university.sql
  • src/main/resources/db/migration/V16__add_unique_constraint_to_intersted.sql
  • src/main/resources/db/migration/V19__create_mentor_related_tables.sql
  • src/main/resources/db/migration/V1__init.sql
  • src/main/resources/db/migration/V21__create_liked_news_table.sql
  • src/main/resources/db/migration/V23__drop_mentoring_reject_reason_column.sql
  • src/main/resources/db/migration/V24__add_chat_related_tables.sql
  • src/main/resources/db/migration/V29__alter_mentor_introduction_pass_tip_not_null.sql
  • src/main/resources/db/migration/V2__add_gpa_score_and_language_test_score.sql
  • src/main/resources/db/migration/V30__modify_verify_status_from_varchar_to_enum.sql
  • src/main/resources/db/migration/V32__add_user_block_table.sql
  • src/main/resources/db/migration/V35__add_mentor_application_table.sql
  • src/main/resources/db/migration/V36__migrate_term_to_table.sql
  • src/main/resources/db/migration/V37__add_unique_constraint_to_mentor_id_mentee_id.sql
  • src/main/resources/db/migration/V38__add_term_id_to_mentor_application.sql
  • src/main/resources/db/migration/V3__add_auth_type_column_and_unique_key.sql
  • src/main/resources/db/migration/V40__create_user_ban_table.sql
  • src/main/resources/db/migration/V41__add_is_deleted_to_post_and_chat_message.sql
  • src/main/resources/db/migration/V42__rename_university_to_host_university_and_create_home_university.sql
  • src/main/resources/db/migration/V43__move_home_university_fk_to_univ_apply_info.sql
  • src/main/resources/db/migration/V45__modify_mentor_introduction_pass_tip_nullable.sql
  • src/main/resources/db/migration/V4__remove_issue_date_columns.sql
  • src/main/resources/db/migration/V5__add_password_column.sql
  • src/main/resources/db/migration/V7__expand_details_column_length.sql
  • src/main/resources/db/migration/V8__add_two_semester_to_semeter_avaliable_enum.sql
  • src/main/resources/logback-spring.xml
  • src/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java
  • src/test/java/com/example/solidconnection/admin/service/AdminUserServiceTest.java
  • src/test/java/com/example/solidconnection/auth/controller/RefreshTokenCookieManagerTest.java
  • src/test/java/com/example/solidconnection/auth/service/AuthTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/JwtTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/service/oauth/OAuthServiceTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/PasswordTemporaryStorageTest.java
  • src/test/java/com/example/solidconnection/auth/service/signup/SignUpTokenProviderTest.java
  • src/test/java/com/example/solidconnection/auth/token/RedisTokenStorageTest.java
  • src/test/java/com/example/solidconnection/chat/service/ChatServiceTest.java
  • src/test/java/com/example/solidconnection/common/filter/HttpLoggingFilterTest.java
  • src/test/java/com/example/solidconnection/common/interceptor/BannedUserInterceptorTest.java
  • src/test/java/com/example/solidconnection/common/resolver/AuthorizedUserResolverTest.java
  • src/test/java/com/example/solidconnection/common/resolver/CustomPageableHandlerMethodArgumentResolverTest.java
  • src/test/java/com/example/solidconnection/community/post/service/PostCommandServiceTest.java
  • src/test/java/com/example/solidconnection/database/FlywayMigrationTest.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixture.java
  • src/test/java/com/example/solidconnection/mentor/fixture/MentorApplicationFixtureBuilder.java
  • src/test/java/com/example/solidconnection/mentor/service/MentorApplicationServiceTest.java
  • src/test/java/com/example/solidconnection/mentor/service/MentoringCommandServiceTest.java
  • src/test/java/com/example/solidconnection/news/service/NewsCommandServiceTest.java
  • src/test/java/com/example/solidconnection/report/fixture/ReportFixtureBuilder.java
  • src/test/java/com/example/solidconnection/s3/service/S3ServiceTest.java
  • src/test/java/com/example/solidconnection/score/service/ScoreServiceTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationProviderTest.java
  • src/test/java/com/example/solidconnection/security/authentication/TokenAuthenticationTest.java
  • src/test/java/com/example/solidconnection/security/filter/ExceptionHandlerFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/SignOutCheckFilterTest.java
  • src/test/java/com/example/solidconnection/security/filter/TokenAuthenticationFilterTest.java
  • src/test/java/com/example/solidconnection/security/userdetails/SiteUserDetailsServiceTest.java
  • src/test/java/com/example/solidconnection/siteuser/fixture/UserBanFixture.java
  • src/test/java/com/example/solidconnection/siteuser/repository/SiteUserRepositoryTest.java
  • src/test/java/com/example/solidconnection/siteuser/service/MyPageServiceTest.java
  • src/test/java/com/example/solidconnection/university/repository/HostUniversityRepositoryForTest.java
  • src/test/java/com/example/solidconnection/university/repository/LikedUnivApplyInfoRepositoryTest.java
  • src/test/java/com/example/solidconnection/university/service/LikedUnivApplyInfoServiceTest.java
  • src/test/java/com/example/solidconnection/university/service/UnivApplyInfoQueryServiceTest.java
  • src/test/resources/application.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:

  • 🔍 Trigger review

✨ Finishing Touches
🧪 Generate unit tests (beta)

  • Create PR with unit tests
  • Commit unit tests in branch refactor/381-coding-convention

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai 변경 사항들을 요약해줘

@whqtker whqtker closed this May 2, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Tip

For best results, initiate chat on the files or code changes.

@whqtker 안녕하세요! 😊 이 PR의 변경 사항을 요약해 드릴게요.


📋 PR #712 변경 사항 요약 — refactor: 코딩 컨벤션 관련 리팩터링

관련 이슈: #381 · 변경 파일: 총 165개


1. 🎨 전체 코드 리포매팅

  • docs/code-style/solid-connection-intellij-scheme.xml 기반으로 프로젝트 전체 코드를 일괄 재포맷했습니다.
  • 들여쓰기, 줄 바꿈, 공백 등 코드 스타일이 전반적으로 통일되었습니다.

2. 🏷️ 엔티티 컬럼에 name 옵션 명시

  • 모든 JPA 엔티티의 @Column 어노테이션에 name 속성을 명시적으로 추가했습니다.
    • 예: @Column@Column(name = "column_name")
  • 영향 파일: SiteUser, Post, Comment, ChatMessage, Mentor, Application 등 전체 도메인 엔티티

3. 🔒 Primitive 타입 필드에 nullable = false 명시

  • int, long, boolean 등 primitive 타입을 가진 모든 컬럼에 @Column(nullable = false)를 명시적으로 추가했습니다.
  • DB 스키마의 명확성을 높이기 위한 작업입니다.

4. 📌 Default 값 필드에 @ColumnDefault 추가

  • 기본값이 있는 필드는 @ColumnDefault 어노테이션으로 값을 명시적으로 표현했습니다.
    • 예: isDeleted, viewCount 등 기본값이 false 또는 0인 필드

📁 주요 변경 파일 분류

카테고리 주요 파일
엔티티 도메인 SiteUser, Post, Comment, ChatRoom, Mentor, Application, GpaScore
DTO MyPageResponse, UnivApplyInfoDetailResponse
서비스 / 레포지토리 AdminUserService, MentorApplicationService, SiteUserFilterRepositoryImpl
DB 마이그레이션 (Flyway) V1__init.sql ~ V45__...sql (포맷 정리)
설정 파일 .github/workflows/prod-cd.yml, logback-spring.xml, .serena/project.yml
테스트 코드 전체 테스트 클래스 일괄 리포맷

ℹ️ 이 PR은 기능 변경 없이 코딩 컨벤션 통일을 목적으로 한 순수 리팩터링입니다. 리뷰 시 로직보다는 어노테이션 일관성 위주로 확인하시면 될 것 같습니다! 😊

@whqtker whqtker reopened this May 2, 2026
@whqtker whqtker added the 최종 리뷰 최소 1명 필수 label May 3, 2026
@whqtker whqtker merged commit 78928a1 into develop May 5, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

리팩터링 최종 리뷰 최소 1명 필수

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: 코딩 컨벤션 관련 리팩터링

2 participants