Skip to content

Nexus 51405 java25 upgrade#276

Open
saicharanvennapusa wants to merge 5 commits intomainfrom
NEXUS-51405-java25-upgrade
Open

Nexus 51405 java25 upgrade#276
saicharanvennapusa wants to merge 5 commits intomainfrom
NEXUS-51405-java25-upgrade

Conversation

@saicharanvennapusa
Copy link
Copy Markdown

@saicharanvennapusa saicharanvennapusa commented Apr 7, 2026

JIRA_TICKET
https://sonatype.atlassian.net/browse/NEXUS-51563

Description

Upgrades Docker images from Java 21 to Java 25 for Nexus Repository Manager

Changes

  • Renamed all Dockerfile..java21 files to Dockerfile..java25
  • Updated package installations:
    • Alpine: openjdk21 → openjdk25
    • UBI9: java-21-openjdk-headless → java-25-openjdk-headless
  • Updated all Jenkinsfiles
  • Updated README.md to reflect Java 25 runtime

Verification

  • ✅ Alpine openjdk25 package confirmed available
  • ✅ UBI9 java-25-openjdk-headless package confirmed available
  • ✅ Docker images build successfully
  • ✅ NXRM containers start and run successfully with Java 25

@saicharanvennapusa saicharanvennapusa requested a review from a team April 7, 2026 13:14
Copy link
Copy Markdown

@archit-mathur archit-mathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: NEXUS-51405 Java 25 Upgrade

⚠️ Warning — Jenkinsfile.rh references Dockerfile.rh.ubi (no Java version suffix)

Jenkinsfile.rh:36 changes dockerfilePath to 'Dockerfile.rh.ubi.java25' but the old value was 'Dockerfile.rh.ubi' (no java suffix). This means there was previously a Dockerfile.rh.ubi file — is this file still present/needed, or was it already renamed to Dockerfile.rh.ubi.java21 before this PR? The PR renames Dockerfile.rh.ubi.java21Dockerfile.rh.ubi.java25 but does not remove or alias any unversioned Dockerfile.rh.ubi. Verify no other pipeline or external reference depends on the old Dockerfile.rh.ubi path.

ℹ️ Info — Changes look correct overall

  • Alpine: openjdk21openjdk25 — PR confirms package availability ✅
  • UBI9/UBI: java-21-openjdk-headlessjava-25-openjdk-headless — PR confirms package availability ✅
  • All Jenkinsfile variable renames (JAVA_21JAVA_25, DOCKERFILE_JAVA_21DOCKERFILE_JAVA_25) are consistent
  • README.md updated correctly to reference new Dockerfile names and Java 25 runtime
  • GitHub Actions workflow updated consistently

ℹ️ Info — No test changes

No test files included. For a Dockerfile-only repo this is expected, but it would be good to confirm CI smoke tests pass (container starts, java -version returns 25) before merge.

@saicharanvennapusa
Copy link
Copy Markdown
Author

When upgrading to java 21 Dockerfile.rh.ubi.java21 name is not updated , it is in Dockerfile.rh.ubi. now updated to Dockerfile.rh.ubi.java25 correctly and updated Readme

Copy link
Copy Markdown

@archit-mathur archit-mathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #276 Review: NEXUS-51405 Java 25 Upgrade (docker-nexus3)

📋 Ticket Alignment

  • Jira Ticket: NEXUS-51405 / NEXUS-51563
  • Scope Alignment: ✅ Aligned — Dockerfile renames java21→java25, Jenkinsfile updates

✅ What This PR Does Well

  • Consistent renames across all Dockerfiles (*.java21*.java25)
  • All three Jenkinsfiles updated consistently
  • README and GitHub Actions updated
  • Package availability verified by author for both Alpine and UBI9
  • Build and runtime test results documented in PR

🔍 Findings (Non-blocking)

# Severity File Finding New/Pre-existing
1 ⚠️ Jenkinsfile.rh:36 Changed from 'Dockerfile.rh.ubi' to 'Dockerfile.rh.ubi.java25' — please confirm no other pipelines reference the old unversioned Dockerfile.rh.ubi path NEW

😈 Devil's Advocate

  • The PR comment from saicharanvennapusa (2026-04-08) confirms this rename was intentional and correctly handled

🧪 Functional Testing

Recommend verifying:

  1. All Docker images build with Java 25 packages
  2. java -version inside container shows OpenJDK 25
  3. Jenkinsfile.rh produces a valid Red Hat certified image

📊 Verdict

  • Recommendation: APPROVE
  • Confidence: High
  • Risk Level: Low (file renames and reference updates only)

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants