Support RFC 6364 and IS-05 SMPTE 2022-5 FEC SDP#505
Open
thangldw wants to merge 2 commits into
Open
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements the layered FEC approach discussed in #38:
FEC/UDP,UDP/FEC,FEC-FR,fec-source-flow,fec-repair-flow, andrepair-windowinsdp/;nmos/sdp*;sdp_parametersrather than synthesizing them from IS-05 values;fec_mode: autoto the highest configured dimension in the example node.RFC / NMOS boundary
The generic SDP representation accepts the RFC 6364 ABNF, including optional parameters and empty FSSI element values. It validates numeric ranges and the RFC token/separator rules.
The NMOS layer deliberately handles only the form IS-05 can represent. RFC-valid multi-source groups remain available in the generic
sdp/JSON but are not converted to FEC transport parameters. Ambiguous/lossy cases, such as two repair flows with different destination addresses, are rejected because IS-05 exposes only onefec_destination_ip.The
fec_enabledfield addition overlaps with #501. It is included here so this PR remains independently buildable frommaster; I will drop the duplicate during rebase if #501 merges first.Tests
nmos-cpp-nodebuildRelated to #38.