WIP: Add kadi-apps command-line executable - #25
Open
javierggt wants to merge 4 commits into
Open
Conversation
javierggt
force-pushed
the
kadi-apps-cmd
branch
2 times, most recently
from
July 11, 2024 01:13
8437a14 to
799cd21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
kadi-appsexecutable that internally starts a kadi-apps test server (if needed). The server stays up until the user explicitly stops it, so later calls to the command start faster. The executable then opens a browser window (after making sure the corresponding port is open).The process management is done internally by launching a
supervisordprocess (which the user can also kill).I have not checked (among other things):
Temporary changes that should be backed out before merging:
Small issues
ERROR (already started). This is not a problem. The server is not started twice.Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
I created a conda environment specifically for testing, both on HEAD and my machine. To create the environment:
if you prefer to use the 2024.7 RC, you can do
Creating the environment takes a while, as usual. After that is done:
This should:
supervisord, a daemon to manage the flask server,It is very possible that it "fails to start" only because it times out. This is faster when the environment is not new. Anyway it is never lightning fast