Add json serialization format for tables in ska_api - #33
Merged
Merged
Conversation
Contributor
|
This looks good to me, but me and Codex note that it doesn't look to go all the way:
|
jeanconn
approved these changes
Sep 9, 2026
jeanconn
left a comment
Contributor
There was a problem hiding this comment.
It looks like there are some outstanding issues with json serialization but this PR moves things in the right direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a json serialization format for tables in ska_api. The current implementation in master accepts two values for
table_format(rows,columns) when returning astropy tables in ska_api methods. Both of these completely ignore the meta data in the table. This PR fixes that by adding a third choice (json) that includes it. An example output is shown in the functional test below.This PR is rebased on top of #36 so the running kadi-test can be used to check that one too.
Interface impacts
No impact on existing interface. This PR adds an argument to methods that return astropy tables.
Testing
This PR also adds a test for the new format choice.
Unit tests
Two tests fail, and they already fail in the main branch:
Independent check of unit tests by Jean
Functional tests
I set up a kadi-apps server in kadi-test and did the following. This is no a necessary test, because the unit test does the same, but still. Note the
metakey: