chore(storybook): nest story groups under Components and Features - #526
Conversation
The sidebar had grown to nine flat top-level groups. Storybook treats `title` as a path of arbitrary depth, so prefixing each group with the directory the component already lives in (src/components/core vs src/components/features) collapses it to two, with no config change. Alphabetical order puts Core above Features on its own. Story IDs change with the titles, so any external deep link into ui.source.coop breaks. Nothing in the repo hardcodes one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Conflicts were both title lines main had renamed. Took main's names (Settings/MembershipsTable and Accounts/InviteMemberForm both became Memberships/*) and re-derived the group prefixes on top. Also renames the Core bucket to Components, and folds main's two new groups in: Memberships, and Object browser (BreadcrumbNav, DirectoryList, ObjectSummary). Object browser is the one exception to the directory rule — BreadcrumbNav lives in src/components/display while its two siblings live under features/products/object-browser. The group goes under Features whole rather than splitting a three-story feature surface across both buckets. Main's rename also dissolved the Accounts split this branch previously had: InviteMemberForm moved to Memberships, so Accounts is now entirely under Components. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Claude finished @alukach's task in 1m 8s —— View job Review of PR #526❌ Changes requested — see findings below.
Everything else checks out: it's a pure 41×1-line Simplify (ponytail): none — this is already the minimal possible diff for a retitle. 💰 Estimated review cost: $0.31 · 1m08s · 13 turns |
alukach
changed the title
1 participant
The ui.source.coop sidebar had grown to a long flat list of top-level groups. This nests them under two: Components and Features.
Storybook treats
titleas a path of arbitrary depth, so this is a pure retitle — one line per story file, no config change:The split follows the directory each component already lives in —
src/components/corevssrc/components/features— so it needs no judgement calls and stays correct as components move.Alphabetical ordering puts Components above Features on its own, so no
storySortinpreview.tsx.One exception
Object browserspans both directories:BreadcrumbNavlives insrc/components/display, whileDirectoryListandObjectSummarylive underfeatures/products/object-browser. The whole group goes underFeaturesrather than splitting a three-story feature surface across both buckets.Tradeoff
Story IDs derive from the title, so every deep link into ui.source.coop changes (
forms-field--default→components-forms-field--default). Nothing in the repo hardcodes one — I grepped foriframe.html?id=and?path=/story/across md/mdx/ts/tsx/json/yml — but any externally bookmarked or Slack-pasted link breaks.Verification
npm run build-storybookpasses on the merged branch. The generatedstorybook-static/index.jsonlists 149 stories across 11 groups, all under the two buckets:🤖 Generated with Claude Code