Skip to content

support drawing horizontal/vertical lines#93

Merged
takenori-y merged 1 commit into
masterfrom
hvline
Jun 8, 2026
Merged

support drawing horizontal/vertical lines#93
takenori-y merged 1 commit into
masterfrom
hvline

Conversation

@takenori-y

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the SPTK draw CLI tools to support drawing additional guide lines (horizontal/vertical) and centralizes grid/guide-related CLI arguments in the shared draw utilities.

Changes:

  • Added shared CLI flags for grid and horizontal/vertical guide lines (including style/color/width) via get_default_parser().
  • Updated multiple draw commands to remove their local -g definition and to render -hline/-vline guides on the Plotly figure.
  • Disabled the new grid/guide options for gspecgram via allow_grid=False.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/draw/sptk/draw_utils.py Adds shared argparse options for grid and horizontal/vertical guide lines; extends get_default_parser() signature.
src/draw/gwave.py Uses shared -g and adds rendering for -hline/-vline guide lines.
src/draw/gspecgram.py Explicitly disables shared grid/guide options (allow_grid=False).
src/draw/gseries.py Uses shared -g and adds rendering for -hline/-vline guide lines.
src/draw/grlogsp.py Uses shared -g and adds rendering for -hline/-vline guide lines.
src/draw/gpolezero.py Uses shared -g and adds rendering for -hline/-vline guide lines.
src/draw/glogsp.py Uses shared -g and adds rendering for -hline/-vline guide lines.
src/draw/fdrw.py Uses shared -g and adds rendering for -hline/-vline guide lines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/draw/sptk/draw_utils.py
Comment thread src/draw/sptk/draw_utils.py
@takenori-y takenori-y merged commit de28bd5 into master Jun 8, 2026
3 checks passed
@takenori-y takenori-y deleted the hvline branch June 8, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants