support drawing horizontal/vertical lines#93
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the SPTK draw CLI tools to support drawing additional guide lines (horizontal/vertical) and centralizes grid/guide-related CLI arguments in the shared draw utilities.
Changes:
- Added shared CLI flags for grid and horizontal/vertical guide lines (including style/color/width) via
get_default_parser(). - Updated multiple draw commands to remove their local
-gdefinition and to render-hline/-vlineguides on the Plotly figure. - Disabled the new grid/guide options for
gspecgramviaallow_grid=False.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/draw/sptk/draw_utils.py |
Adds shared argparse options for grid and horizontal/vertical guide lines; extends get_default_parser() signature. |
src/draw/gwave.py |
Uses shared -g and adds rendering for -hline/-vline guide lines. |
src/draw/gspecgram.py |
Explicitly disables shared grid/guide options (allow_grid=False). |
src/draw/gseries.py |
Uses shared -g and adds rendering for -hline/-vline guide lines. |
src/draw/grlogsp.py |
Uses shared -g and adds rendering for -hline/-vline guide lines. |
src/draw/gpolezero.py |
Uses shared -g and adds rendering for -hline/-vline guide lines. |
src/draw/glogsp.py |
Uses shared -g and adds rendering for -hline/-vline guide lines. |
src/draw/fdrw.py |
Uses shared -g and adds rendering for -hline/-vline guide lines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.