Add romanisim package to devdeps - #2184
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 132 132
Lines 7419 7419
=======================================
Hits 6237 6237
Misses 1182 1182 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Sorry I had lost track of #1914, approved. |
f430d10 to
bd568f1
Compare
|
Since this is a devdeps change I added the extra tests label and disabled automerge (to avoid merging before the devdeps jobs finish). |
|
devdeps picked up the changes: |
|
@ddavis-stsci would you give this a review since it's merging is blocked by needing maintainer approval? |
bd568f1 to
a0af635
Compare
a0af635 to
e74e57f
Compare
|
Unfortunately, since |
|
Why did this work prior to #1914 being merged? |
|
Oh of course, you're absolutely right |
Pull request was converted to draft
|
I moved this back to draft since it's no longer working. |
255cf4e to
a4ee0be
Compare
f5d9578 to
e0f370e
Compare
|
looks like that worked |
e0f370e to
8c34150
Compare
8c34150 to
5313e40
Compare
|
I was trying to come back and clean up some of these old PRs and took another look at this one. @zacharyburnett , if you get a chance, could you see if the devdeps errors make sense to you? |
7579ef1 to
9d75664
Compare
|
So the problem here is we're requesting I'm unsure how to make this work with the current version of This also means that now our existing |
|
I'll see if an older version of |
braingram
left a comment
There was a problem hiding this comment.
Looks like it's not pulling in main from the version (0.14.0):
https://github.com/spacetelescope/romancal/actions/runs/35661144536/job/106536484534?pr=2184#step:11:116
@schlafly the pin in pyproject.toml doesn't allow 0.15.0:
Line 30 in 15cb2e3
which appears to be the latest release:
https://github.com/spacetelescope/romanisim/releases/tag/v0.15.0
Does something need updating?
|
Thanks, I'm trying to loosen the pin here: #2463 |
|
This finally looks good. It was useful; I had broken romancal in spacetelescope/romanisim#379, so I fixed romanisim in spacetelescope/romanisim#396, fixing the issue. That had the side effect of verifying that this PR is now functional. I'm ready to merge this. |
We don't currently test against romanisim main in our devdeps, but we probably should? This PR adds romanisim to the list of devdeps we test nightly against.