Repository navigation
Add a portable count_trailing_zeroes implementation, use it for faster depth_for_size - #146
Merged
Merged
Conversation
Contributor
|
As mentioned in #145, the original implementation took 17s on buddy_bench. The intrinsic version I drummed up took 13s. This PR takes 14s. Pretty good considering it's also portable! |
Owner
Author
|
@theVerySharpFlat thanks for the report and for testing the pr too! It is nice to have more eyes on the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #145 the
depth_for_sizefunction can be implemented without the loop. The chosencount_trailing_zeroesis not the fastest one out there but its simplicity makes it preferable.