Skip to content

Handle json_bi results with development mode sql warnings #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DylanBaker merged 2 commits into from
Jul 29, 2026
Merged

Handle json_bi results with development mode sql warnings #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f53305
handle json_bi results with development mode sql warnings
Jul 29, 2026
c433504
bump spectacles 2.4.19 -> 2.4.20
Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "spectacles"
version = "2.4.19"
version = "2.4.20"
description = "A command-line, continuous integration tool for Looker and LookML."
authors = ["Spectacles <hello@spectacles.dev>"]
license = "MIT"
Expand Down
2 changes: 0 additions & 2 deletions spectacles/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ def errors(self) -> Tuple[QueryError, ...]:
raise TypeError("No errors contained in this query result")
return self.data.errors
elif isinstance(self.data, self.JsonBiError):
if not self.data.rows:
raise TypeError("No errors contained in this query result")
return self.data.errors
else:
raise TypeError("Unexpected type for ErrorQueryResult.data")
Expand Down
14 changes: 10 additions & 4 deletions spectacles/validators/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,13 +364,19 @@ async def _get_query_results(
queries_to_run.task_done()
else:
query_slot.release()
query.errored = True

errors = query_result.get_valid_errors()
query.errored = bool(errors)

if not errors:
for dimension in query.dimensions:
dimension.queried = True

# Fail fast, assign the error(s) to its explore
if fail_fast:
elif fail_fast:
explore = query.explore
explore.queried = True
for error in query_result.get_valid_errors():
for error in errors:
line_number = (
error.sql_error_loc.line
if error.sql_error_loc
Expand All @@ -397,7 +403,7 @@ async def _get_query_results(
elif len(query.dimensions) == 1:
dimension = query.dimensions[0]
dimension.queried = True
for error in query_result.get_valid_errors():
for error in errors:
line_number = (
error.sql_error_loc.line
if error.sql_error_loc
Expand Down