Skip to content

docs: issue #61 workbook-level shape meta design update - #62

Merged
ssaattww merged 3 commits into
masterfrom
feature/issue61-workbook-meta-shape
Apr 16, 2026
Merged

docs: issue #61 workbook-level shape meta design update#62
ssaattww merged 3 commits into
masterfrom
feature/issue61-workbook-meta-shape

Conversation

@ssaattww

Copy link
Copy Markdown
Owner

Summary

  • update issue ExcelTemplateのsheetのrepeat対応 #61 design to use workbook-level XML metadata in shape text
  • fix shape naming rule to read only __workbook_meta on __sheet_meta
  • sync design report and task/phase tracking with detailed phase/task breakdown

Notes

  • this is a documentation/planning PR created first as requested
  • implementation tasks are listed in tasks/tasks-status.md (R61-02..R61-08)

Refs #61

@ssaattww ssaattww linked an issue Apr 16, 2026 that may be closed by this pull request
@ssaattww
ssaattww marked this pull request as ready for review April 16, 2026 05:55
@ssaattww
ssaattww merged commit 0913c05 into master Apr 16, 2026
1 check passed
@ssaattww
ssaattww deleted the feature/issue61-workbook-meta-shape branch April 16, 2026 05:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3d66fb2f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +372 to +374
var nameVariableScope = string.IsNullOrWhiteSpace(variableName)
? EmptyVariableNames
: new HashSet<string>(StringComparer.Ordinal) { variableName };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use implicit item scope for sheet name normalization

When a workbook-meta <sheet> has from but omits var, runtime defaults the loop variable to item, but this branch normalizes name with EmptyVariableNames. For a name like @item, ExcelTemplateExpressionNormalizer rewrites it to @(root.Item) instead of @(item), so repeated sheet names resolve against root data (or fail) rather than the current iteration item. This only appears when from is set and var is omitted, but in that valid format it produces incorrect sheet naming behavior.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExcelTemplateのsheetのrepeat対応

1 participant