docs: issue #61 workbook-level shape meta design update - #62
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3d66fb2f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var nameVariableScope = string.IsNullOrWhiteSpace(variableName) | ||
| ? EmptyVariableNames | ||
| : new HashSet<string>(StringComparer.Ordinal) { variableName }; |
There was a problem hiding this comment.
Use implicit
item scope for sheet name normalization
When a workbook-meta <sheet> has from but omits var, runtime defaults the loop variable to item, but this branch normalizes name with EmptyVariableNames. For a name like @item, ExcelTemplateExpressionNormalizer rewrites it to @(root.Item) instead of @(item), so repeated sheet names resolve against root data (or fail) rather than the current iteration item. This only appears when from is set and var is omitted, but in that valid format it produces incorrect sheet naming behavior.
Useful? React with 👍 / 👎.
Summary
__workbook_metaon__sheet_metaNotes
tasks/tasks-status.md(R61-02..R61-08)Refs #61