Skip to content

Fix/prometheus metrics registration edge case bug - #13

Closed
amirhnajafiz wants to merge 5 commits into
ssmirr:masterfrom
amirhnajafiz:fix/prometheus-metrics-registration-edge-case-bug
Closed

Fix/prometheus metrics registration edge case bug#13
amirhnajafiz wants to merge 5 commits into
ssmirr:masterfrom
amirhnajafiz:fix/prometheus-metrics-registration-edge-case-bug

Conversation

@amirhnajafiz

Copy link
Copy Markdown

ChangeLog

  • Replaced Prometheus MustRegister with Register for safe and dynamic metric registration.
  • Added subsystem to metrics for better semantics.
  • Set Prometheus server timeouts.

Why?

  • Fixing potential runtime failures.
  • Keeping the Prometheus server fast and healthy.

@amirhnajafiz

Copy link
Copy Markdown
Author

@ssmirr Please sync the latest changes from Psiphone-Inc repository. There is a bug fix for Prometheus metrics. I'll close this PR since the fix has already been merged into the main repository.

@amirhnajafiz
amirhnajafiz deleted the fix/prometheus-metrics-registration-edge-case-bug branch February 11, 2026 21:16
@ssmirr

ssmirr commented Feb 14, 2026

Copy link
Copy Markdown
Owner

Sorry it took me a while to get back to review and merge this one, and thanks for letting me know this is now fixed in upstream! I'm going to pull all latest changes from upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants