Feat/remove host port settings - #972
Merged
Merged
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'STAC FastAPI Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: f1e0e7c | Previous: 23e32ef | Ratio |
|---|---|---|---|
Items With Model validation (1) |
643.4864504164253 iter/sec (stddev: 0.0003411241481286381) |
1114.3950430418508 iter/sec (stddev: 0.00007765269469840097) |
1.73 |
Items With Model validation (10) |
518.7818065796886 iter/sec (stddev: 0.00010095391860553807) |
800.3197579774019 iter/sec (stddev: 0.00003540663655319268) |
1.54 |
Items With Model validation (50) |
219.93794391700894 iter/sec (stddev: 0.003434723245871479) |
310.5055039365144 iter/sec (stddev: 0.0027953900761542856) |
1.41 |
Items With Model validation (100) |
126.10717132631814 iter/sec (stddev: 0.004717585429711609) |
169.17178989753182 iter/sec (stddev: 0.004211809988101109) |
1.34 |
Items With Model validation (200) |
71.30050855762285 iter/sec (stddev: 0.007506761264451429) |
93.53038032017731 iter/sec (stddev: 0.006246738065621293) |
1.31 |
Items Limit: (1) |
808.8538517662872 iter/sec (stddev: 0.00006622080483310884) |
1062.7879723635724 iter/sec (stddev: 0.000019389827171156694) |
1.31 |
Items Limit: (10) |
523.2269257870913 iter/sec (stddev: 0.0000602481950074379) |
778.5078915507469 iter/sec (stddev: 0.00006818861163340254) |
1.49 |
Items Limit: (50) |
269.51693205526203 iter/sec (stddev: 0.00008624637553651985) |
359.1192369901714 iter/sec (stddev: 0.000030407709450028772) |
1.33 |
Items Limit: (200) |
85.7451669892919 iter/sec (stddev: 0.004747492730056496) |
113.92154589552123 iter/sec (stddev: 0.003065109745233152) |
1.33 |
Items Limit: (250) |
71.71053299665071 iter/sec (stddev: 0.004321974066426941) |
96.93291040973263 iter/sec (stddev: 0.0001182399117656769) |
1.35 |
Items Limit: (1000) |
17.52257522293062 iter/sec (stddev: 0.00922278356899566) |
24.86524368214888 iter/sec (stddev: 0.0064309829441357635) |
1.42 |
Collection With Model validation |
779.6825943343857 iter/sec (stddev: 0.00003879504648526545) |
1474.3181725695035 iter/sec (stddev: 0.000028087036218428864) |
1.89 |
Collection |
857.0621128703572 iter/sec (stddev: 0.00010368522037611454) |
1481.0845895308935 iter/sec (stddev: 0.000039520349727738754) |
1.73 |
Collections With Model validation |
716.6619452552252 iter/sec (stddev: 0.000032887207231310175) |
1089.0463553644822 iter/sec (stddev: 0.00002469948009357216) |
1.52 |
Collections |
635.2012027095676 iter/sec (stddev: 0.00006513245889747792) |
925.8435082819555 iter/sec (stddev: 0.00007241663989307077) |
1.46 |
This comment was automatically generated by workflow using github-action-benchmark.
jonhealy1
marked this pull request as ready for review
August 29, 2026 09:03
vincentsarago
self-requested a review
September 7, 2026 12:28
vincentsarago
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
This is a reopening of #964 which was merged prematurely.
PR Checklist:
pre-commithooks pass locallymake test)make docs)