Skip to content

feat: change output to json object for bulk transaction endpoints - #975

Merged
vincentsarago merged 3 commits into
mainfrom
feat/extension-bulk-transaction-output-json
Sep 4, 2026
Merged

feat: change output to json object for bulk transaction endpoints#975
vincentsarago merged 3 commits into
mainfrom
feat/extension-bulk-transaction-output-json

Conversation

@vincentsarago

Copy link
Copy Markdown
Member

Related Issue(s):

Description:

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

received: int
success: int
skipped: int
errors: list[TransactionError]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposal for the output model

"success": 1,
"skipped": 0,
"errors": [{"id": "test_item", "msg": "Item already exists"}],
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full example with error message

@gadomski gadomski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a CHANGES.md update?

@vincentsarago

Copy link
Copy Markdown
Member Author

@jonhealy1 any opinions?

@jonhealy1 jonhealy1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vincentsarago
vincentsarago merged commit 44345f1 into main Sep 4, 2026
6 checks passed
@vincentsarago
vincentsarago deleted the feat/extension-bulk-transaction-output-json branch September 4, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants