updating release workflow to sign windows MSIs and binaries#107
Merged
Conversation
…ning Adds Authenticode signing for Windows .exe and .msi artifacts as part of the release workflow, using Azure Trusted Signing via OIDC federation. Sigstore signing for Windows artifacts moves post-Authenticode so cosign bundles cover the bytes users actually download. - release.yml: new windows-sign-and-package job gated on the `release` GitHub Environment (two reviewers, main-only). Workflow signs the 4 Windows .exes (agent + launcher × amd64 + arm64), builds 2 MSIs from the signed exes, Authenticode-signs the MSIs, then sigstore-signs everything and attests build provenance. Uses azure/login OIDC + the Azure/trusted-signing-action. cache-dependencies: false works around a same-job silent-exit bug when the action runs twice. - test-azure-signing.yml: new manual-trigger smoke test for the OIDC -> Azure -> signtool path. Builds throwaway snapshot binaries, signs and verifies, uploads signed artifacts for offline inspection. Does not tag or touch any release. - docs/release-process.md: documents the approval gate, the new Windows verification commands (Get-AuthenticodeSignature + signtool verify /pa + cosign + gh attestation verify), and the Authenticode + RFC3161 timestamp guarantee. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
varunsh-coder
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues