fix: harden builtin TUI theme readability - #24
Open
xy200303 wants to merge 4 commits into
Open
Conversation
Collaborator
|
Thanks for the contribution! To get this ready to merge:
Full conventions: |
…bility # Conflicts: # docs/skills/pr-review-decision.md # package.json
Contributor
Author
|
Thanks! I've addressed the feedback on this PR:
This should be ready for review/merge when you have a chance. |
li-xiu-qi
added a commit
to li-xiu-qi/Step-Realtime-CLI
that referenced
this pull request
Aug 7, 2026
- 待办 stepfun-ai#17:delivered 事件此前在注入/入队时即时落盘,消息本体回合末 persist 才落盘,中间崩溃让对账误判已送达、通知丢失。改为 persist 时 扫 history 统一补写(pendingDeliveredEvents 纯函数,幂等键去重), 两者同生共死;Esc 丢弃队列的通知在丢弃处显式补写,保持「丢弃即送达」。 App.tsx 同文件还含 /think /provider 写回配置的调用点(上一笔的实现)。 - 待办 stepfun-ai#24 + #0 遗留:ModelPicker 块分页改居中锚定滑动窗口、截断/填充 改 displayWidth 口径(新增 padEndByWidth);ModelPicker/ThinkPicker 加 visibleRows 入参,App 按 resolveVisibleRows 同口径接线(多留 1 行 chrome 余量),小终端弹层不再越线。
li-xiu-qi
added a commit
to li-xiu-qi/Step-Realtime-CLI
that referenced
this pull request
Aug 7, 2026
- 待办 stepfun-ai#17:delivered 事件此前在注入/入队时即时落盘,消息本体回合末 persist 才落盘,中间崩溃让对账误判已送达、通知丢失。改为 persist 时 扫 history 统一补写(pendingDeliveredEvents 纯函数,幂等键去重), 两者同生共死;Esc 丢弃队列的通知在丢弃处显式补写,保持「丢弃即送达」。 App.tsx 同文件还含 /think /provider 写回配置的调用点(上一笔的实现)。 - 待办 stepfun-ai#24 + #0 遗留:ModelPicker 块分页改居中锚定滑动窗口、截断/填充 改 displayWidth 口径(新增 padEndByWidth);ModelPicker/ThinkPicker 加 visibleRows 入参,App 按 resolveVisibleRows 同口径接线(多留 1 行 chrome 余量),小终端弹层不再越线。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/themeswitches on macOS terminals.mainand make the newly merged Windows-sensitive tests pass under normal Windows permissions.What Changed
mutedandlinecolors insrc/tui/theme.tsacrossdefault,sage,pop,helix, andsteel.SUMMARYlabel insrc/tui/app.tsxto usetheme.foregroundfor badge text while preserving existing badge background and rail colors./themestatus copy so users can recover quickly with/theme defaultwhen a custom or builtin theme is hard to read.src/tui/theme.test.tsto verify contrast constraints for foreground, muted text, selections, dividers/rails, and badge backgrounds.pnpm checkpasses under normal Windows permissions.Verification
pnpm exec vitest run src/tui/theme.test.tspnpm exec vitest run packages/utils/src/path.test.ts packages/utils/src/shell.test.tspnpm exec tsc --noEmit --pretty falsepnpm exec prettier --check src/tui/theme.ts src/tui/app.tsx src/tui/theme.test.ts packages/utils/src/path.test.ts packages/utils/src/shell.test.ts docs/skills/pr-review-decision.mdpnpm checkNotes