Skip to content
This repository was archived by the owner on Jan 3, 2019. It is now read-only.

Add backgroundColor and labelColor for Donut#46

Closed
rechl wants to merge 1 commit into
stewones:masterfrom
rechl:patch-1
Closed

Add backgroundColor and labelColor for Donut#46
rechl wants to merge 1 commit into
stewones:masterfrom
rechl:patch-1

Conversation

@rechl

@rechl rechl commented Mar 23, 2016

Copy link
Copy Markdown

I would need these both here. They were not documented at morris.js (PR for doc update here: morrisjs/morris.js#654)

Take care, i have not tested this

I would need these both here. They were not documented at morris.js (PR for doc update  here: morrisjs/morris.js#654)  

Take care, i have not tested this
@stewones

Copy link
Copy Markdown
Owner

hi @sgotre
thanks for contributing but we need tests for new features. I'll review and patch asap

@skol-pro

Copy link
Copy Markdown

I was about to pull request this too. I confirm it's working.

@stewones

Copy link
Copy Markdown
Owner

@sgotre
i'm able to accept but this PR does not inlude a minified version
you should run gulp build before commit. like mentioned in contributing

@rechl

rechl commented Mar 30, 2016

Copy link
Copy Markdown
Author

I will close this PR for a new and tested one.

@rechl rechl closed this Mar 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants