Skip to content

fix(hci): gate Coded PHY command parameters - #133

Merged
stoprocent merged 1 commit into
mainfrom
agent/gate-extended-coded-phy
Aug 4, 2026
Merged

stoprocent merged 1 commit into
mainfrom
agent/gate-extended-coded-phy

Conversation

@stoprocent

Copy link
Copy Markdown
Owner

Fixes #132

Summary

  • include LE Coded scan parameters only when LE Supported Features advertises Coded PHY support
  • include LE Coded initiating parameters only for a capable controller
  • retain the existing LE 1M + LE Coded commands byte-for-byte on capable controllers
  • leave legacy scan and connection commands unchanged

Unknown support is treated as unsupported, so extended commands remain valid before or after a failed feature read.

Validation

The two unsupported-controller regression cases were added first and failed against the previous implementation with the expected 0x05 PHY masks and extra parameter blocks.

After the production change:

  • focused HCI suite: 175 passed
  • full suite: 19 suites passed, 801 passed, 1 skipped
  • lint: passed

@stoprocent
stoprocent force-pushed the agent/gate-extended-coded-phy branch from 176b7b9 to f8bed16 Compare August 4, 2026 19:22
@stoprocent
stoprocent merged commit ede9115 into main Aug 4, 2026
29 checks passed
@stoprocent
stoprocent deleted the agent/gate-extended-coded-phy branch August 4, 2026 19:35
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LE Coded PHY is offered on the extended scan and connect paths without checking the Coded PHY feature bit

1 participant