Skip to content

CI: node-gyp 10 cannot detect Visual Studio 18 on windows-latest #23

Description

@stoprocent

Summary

The Windows build and Node 20 test jobs now fail during npm ci before repository code is compiled.

windows-latest exposes Visual Studio 18, while the Node 20 bundled node-gyp@10.1.0 reports:

gyp ERR! find VS unknown version "undefined" found at "C:\Program Files\Microsoft Visual Studio\18\Enterprise"
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use

Affected jobs

  • Build win32-x86
  • test (20.x, windows-latest, x64)

Both push and pull-request workflow runs fail at the same npm ci stage. This is independent of the C++ patch in #22.

Proposed fix

Pin the Windows build and test matrix entries to windows-2022, which provides the Visual Studio toolchain supported by the Node 18/20 node-gyp versions used here. Keep this change isolated from feature PRs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions