Skip to content

Return Header from Sv2Frame::get_header#2211

Open
DeepCogNeural wants to merge 1 commit into
stratum-mining:mainfrom
DeepCogNeural:codex/stratum-get-header
Open

Return Header from Sv2Frame::get_header#2211
DeepCogNeural wants to merge 1 commit into
stratum-mining:mainfrom
DeepCogNeural:codex/stratum-get-header

Conversation

@DeepCogNeural

@DeepCogNeural DeepCogNeural commented Jun 23, 2026

Copy link
Copy Markdown

Summary

  • Change Sv2Frame::get_header() to return Header directly instead of Option<Header>.
  • Update related tests and examples to remove impossible None handling.

Fixes #2112.
companion stratum-mining/sv2-apps#584

Verification

  • cargo fmt --all --check
  • cargo test -p framing_sv2
  • cargo test -p codec_sv2
  • cargo check --workspace --all-targets
  • git diff --check

Companion verification:

  • cargo fmt --all --check in integration-tests, miner-apps, pool-apps, and stratum-apps
  • cargo check --manifest-path integration-tests/Cargo.toml with stratum-core patched to this PR checkout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sv2Frame get_header() returns Option<Header> but is always Some

1 participant