Skip to content

Change logger identifier from 'index' to 'test-utils' - #3316

Merged
mondoreale merged 2 commits into
avoid-nodejs-modulefrom
copilot/sub-pr-3309-another-one
Dec 26, 2025
Merged

mondoreale merged 2 commits into
avoid-nodejs-modulefrom
copilot/sub-pr-3309-another-one

Conversation

Copilot AI commented Dec 26, 2025 •

Copy link
Copy Markdown
Contributor

Summary

Addresses feedback on PR #3309 to use a more descriptive logger identifier for improved log tracing.

Changes

  • Changed logger identifier from 'index' to 'test-utils' in packages/test-utils/src/index.ts

The generic 'index' identifier made it difficult to distinguish logs when multiple packages have index.ts files. The new identifier aligns with the package name @streamr/test-utils.

Checklist before requesting a review

  • Is this a breaking change? If it is, be clear in summary.
  • Read through code myself one more time.
  • Make sure any and all TODO comments left behind are meant to be left in.
  • Has reasonable passing test coverage?
  • Updated changelog if applicable.
  • Updated documentation if applicable.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Note

Logging

  • Update logger initialization to new Logger('test-utils') (was 'index') in packages/test-utils/src/index.ts to improve log namespacing.

Written by Cursor Bugbot for commit f5f936e. This will update automatically on new commits. Configure here.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: mondoreale <320066+mondoreale@users.noreply.github.com>

Copilot AI commented Dec 26, 2025

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chrome-for-testing-public/121.0.6167.184/linux64/chromedriver-linux64.zip
    • Triggering command: /usr/local/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on avoiding NodeJS-specific module usage Change logger identifier from 'index' to 'test-utils' Dec 26, 2025
Copilot AI requested a review from mondoreale December 26, 2025 18:16
@mondoreale
mondoreale marked this pull request as ready for review December 26, 2025 18:17
@mondoreale
mondoreale merged commit c21557f into avoid-nodejs-module Dec 26, 2025
1 check passed
@mondoreale
mondoreale deleted the copilot/sub-pr-3309-another-one branch December 26, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants