Skip to content

feat: fvm support - #383

Merged
bartekpacia merged 5 commits into
subosito:mainfrom
pedroafmonteiro:feat/fvm-support
Mar 18, 2026
Merged

feat: fvm support#383
bartekpacia merged 5 commits into
subosito:mainfrom
pedroafmonteiro:feat/fvm-support

Conversation

@pedroafmonteiro

@pedroafmonteiro pedroafmonteiro commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Closes #296

This pull request extends Flutter version detection to support FVM config files in addition to pubspec.yaml. I decided to try to implement this feature due to changes on NIAEFEUP/uni #1814. Actions are failing because it cannot detect this file.

  • updated the documentation in README.md to explain that Flutter version can now be sourced from .fvmrc or fvm_config.json, in addition to pubspec.yaml.
  • modified the flutter-version-file input description in action.yaml.
  • the setup.sh script now detects FVM config files and extracts the Flutter version using jq, while continuing to use yq for pubspec.yaml. channel/version assignment logic for special cases like "stable", "beta", "master", and "main" continue to be supported.
  • windows runner logic in action.yaml only installs yq if the version file is not an FVM config file, since FVM config files are parsed with jq instead

@coderabbitai

coderabbitai Bot commented Mar 9, 2026

Copy link
Copy Markdown

removed by @bartekpacia

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REMOVED by @bartekpacia

@pedroafmonteiro

Copy link
Copy Markdown
Contributor Author

Hey @bartekpacia, any chance you could check this out? This would help very much the development of many projects here. Thanks! :)

@bartekpacia

Copy link
Copy Markdown
Collaborator

Ooo hi @pedroafmonteiro! Sure let me take a look:)

Comment thread action.yaml Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@kuhnroyal

Copy link
Copy Markdown
Contributor

Linking some issues here for reference: #101 #296

The topic of FVM support has been discussed multiple times in the past and was decided against for different reasons. Personally, I would be glad if I could sunset https://github.com/kuhnroyal/flutter-fvm-config-action

@bartekpacia

bartekpacia commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks @kuhnroyal for sharing the additional context.

@pedroafmonteiro could you edit the PR description to include "resolves #296"?

Oh, and please also rebase with master so that CI will pass. It was caused by #387 which I have just fixed.

@pedroafmonteiro

Copy link
Copy Markdown
Contributor Author

Hi! Yes, I will fix those issues right now, sorry for the delay!

@bartekpacia bartekpacia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bartekpacia
bartekpacia merged commit 6622f58 into subosito:main Mar 18, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow fvm config files as source for flutter-version-file

3 participants