feat: fvm support - #383
Conversation
|
removed by @bartekpacia |
|
Hey @bartekpacia, any chance you could check this out? This would help very much the development of many projects here. Thanks! :) |
|
Ooo hi @pedroafmonteiro! Sure let me take a look:) |
|
Linking some issues here for reference: #101 #296 The topic of FVM support has been discussed multiple times in the past and was decided against for different reasons. Personally, I would be glad if I could sunset https://github.com/kuhnroyal/flutter-fvm-config-action |
|
Thanks @kuhnroyal for sharing the additional context. @pedroafmonteiro could you edit the PR description to include "resolves #296"? Oh, and please also rebase with master so that CI will pass. It was caused by #387 which I have just fixed. |
|
Hi! Yes, I will fix those issues right now, sorry for the delay! |
Closes #296
This pull request extends Flutter version detection to support FVM config files in addition to
pubspec.yaml. I decided to try to implement this feature due to changes on NIAEFEUP/uni #1814. Actions are failing because it cannot detect this file.README.mdto explain that Flutter version can now be sourced from.fvmrcorfvm_config.json, in addition topubspec.yaml.flutter-version-fileinput description inaction.yaml.setup.shscript now detects FVM config files and extracts the Flutter version usingjq, while continuing to useyqforpubspec.yaml. channel/version assignment logic for special cases like "stable", "beta", "master", and "main" continue to be supported.action.yamlonly installsyqif the version file is not an FVM config file, since FVM config files are parsed withjqinstead