test: ratchet GASP geometry tests away from global option defaults - #1
Closed
suhaslord wants to merge 174 commits into
Closed
test: ratchet GASP geometry tests away from global option defaults#1suhaslord wants to merge 174 commits into
suhaslord wants to merge 174 commits into
Conversation
…wo fuselage points, which are overwritten anyway.
Fixed a bug where an extra constraint was added to solved 2dof
Multi-Fuel preparation
Version-specific documentation
Remove get_option_defaults() from V3_bug_fixed_IO.py
Converted Aircraft.Fuselage.AISLE_WIDTH from an option to a variable
suhaslord
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a focused chunk of OpenMDAO#1251.
This turns the first GASP geometry slice away from
get_option_defaults()and adds a migration ratchet so new geometry tests cannot reintroduce the same hidden dependency while the remaining larger legacy modules are cleaned up incrementally.What changed
AviaryValuesget_option_defaultsimports in GASP geometry teststest_fuselage.py,test_size_group.py,test_wing.py) grandfathered for follow-up cleanupWhy
The tests now expose the option dependencies they actually need instead of silently inheriting the full metadata default set. The guard makes this a one-way migration: legacy uses can disappear without updating the test, but new uses fail.
Scope
Test infrastructure only; no production-model behavior changes.
Current branch is based on the latest upstream
main. Full Aviary Tests, docs, and benchmark workflows are running on the fork before upstream submission.