test: make descent FlightODE option contract explicit - #5
Draft
suhaslord wants to merge 11 commits into
Draft
Conversation
Ruff-format requires the AviaryValues argument to be on a single line. This fixes the pre-commit hook failure. Co-authored-by: Suhas <suhaslord@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First evidence-backed migration slice from the OpenMDAO#1251 option-default control plane.
Runtime tracing across the two-DOF ODE tests showed that the inline
get_option_defaults()passed directly to the descentFlightODEreads exactly one inherited value:Settings.VERBOSITY. Its metadata default isVerbosity.BRIEF.Change
AviaryValuescontract forSettings.VERBOSITYRatchet movement
get_option_defaults()callsThis is intentionally small in code size but not guessed: it is the first conversion produced by the static + runtime dependency framework, and it demonstrates the repeatable migration loop before tackling the builder-heavy call sites.